Skip to content

Display actual instance operation states in helix-front UI#136

Merged
Chr0nicl3 merged 2 commits into
devfrom
ktripath/helixFrontInstanceOperationStates
Mar 25, 2026
Merged

Display actual instance operation states in helix-front UI#136
Chr0nicl3 merged 2 commits into
devfrom
ktripath/helixFrontInstanceOperationStates

Conversation

@Chr0nicl3
Copy link
Copy Markdown
Collaborator

@Chr0nicl3 Chr0nicl3 commented Mar 24, 2026

The helix-front UI previously only distinguished between enabled/disabled and online/offline, causing hosts in UNKNOWN, EVACUATE, or SWAP_IN states to display as disabled or offline, leading to confusion during incident response. Now that the getAllInstances API returns granular operation state categorization (PR #75), update the frontend to consume and render these states with distinct icons, colors, and labels.

Refs: ACTIONITEM-14217
Made-with: Cursor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

Tests

Screenshot 2026-03-24 at 12 36 18 PM Screenshot 2026-03-24 at 12 36 31 PM
  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Karan Tripathi added 2 commits March 24, 2026 11:54
The helix-front UI previously only distinguished between enabled/disabled
and online/offline, causing hosts in UNKNOWN, EVACUATE, or SWAP_IN states
to display as disabled or offline, leading to confusion during incident
response. Now that the getAllInstances API returns granular operation state
categorization (PR #75), update the frontend to consume and render these
states with distinct icons, colors, and labels.

Refs: ACTIONITEM-14217
Made-with: Cursor
Cover the Instance model, InstanceService (getAll/get API parsing),
InstanceListComponent, and InstanceDetailComponent with Jest tests
that verify correct mapping of ENABLE, DISABLE, EVACUATE, SWAP_IN,
and UNKNOWN states, including fallback logic and the
INSTANCE_OPERATION_STATE field read.

Made-with: Cursor
Copy link
Copy Markdown
Collaborator

@proud-parselmouth proud-parselmouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Chr0nicl3 Chr0nicl3 merged commit e5998a8 into dev Mar 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants