Added override for DB Engine Config view commands#776
Merged
ezilber-akamai merged 1 commit intoMay 29, 2025
Conversation
ezilber-akamai
added
the
improvement
ezilber-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
added
the
do-not-merge
ezilber-akamai
force-pushed
the
TPT-3750-db-engine-config
branch
from
3bf5a10 to
146dc44
Compare
ezilber-akamai
force-pushed
the
TPT-3750-db-engine-config
branch
from
146dc44 to
8da21a7
Compare
ykim-akamai
approved these changes
May 26, 2025
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
Looks great! thanks for the quick fix
lgarber-akamai
approved these changes
May 29, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great and works well on my end!
ezilber-akamai
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added override to properly construct tables for DB Engine Config view commands.
✔️ How to Test
Manually run
linode-cli databases mysql-config-viewandlinode-cli databases postgres-config-viewafter checking out this PR and building against the proper spec. Confirm that the tables are properly populated and look correct.