Fix support for deeply nested oneOfs; group nested oneOf options on help pages#785
Merged
lgarber-akamai merged 4 commits intoAug 7, 2025
Merged
Conversation
be0421d to
25d4024
Compare
12d8ce6 to
23cab4e
Compare
yec-akamai
approved these changes
Jul 25, 2025
Contributor
yec-akamai
left a comment
There was a problem hiding this comment.
Tested and works well on my end!
ezilber-akamai
approved these changes
Aug 7, 2025
Contributor
ezilber-akamai
left a comment
There was a problem hiding this comment.
Works well locally!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request resolves a regression that occurred in
v5.58.0alongside the Linode Interfaces release, where the arguments used to specify nested config interface arguments (e.g.--interfaces.purpose) disappeared. This was partially the result of an issue with the spec and partially an issue with how the CLI parses nested oneOfs.NOTE: Because the CLI does not currently support rendering options on nested fields on help pages, the help page ouput is a bit difficult to parse. We should resolve this in a follow-up ticket.
✔️ How to Test
The following test steps assume you have pulled down this PR locally and run the following:
Integration Testing
Unit Testing
Manual Testing
linode-cli vpcs create --json \ --label test-vpc \ --region us-mia \ --subnets.label my-subnet \ --subnets.ipv4 '10.0.0.0/24'