Conversation
vshanthe
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive integration tests for dual-stack (IPv4 + IPv6) VPC functionality, including VPC creation with IPv6 ranges, subnet creation with IPv6 support, and IP address listing capabilities.
Key changes:
- Added tests for automatic and custom IPv6 range allocation for VPCs and subnets
- Added tests for listing VPC IPv4 and IPv6 addresses
- Updated VPC test fixtures to support IPv6 by default
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/vpc/test_vpc.py | Adds 5 new test functions covering IPv6 VPC creation, subnet creation with IPv6, invalid IPv6 range handling, and IP address listing |
| tests/integration/vpc/conftest.py | Updates fixtures to handle list-wrapped VPC responses and enables IPv6 for test VPCs |
| tests/integration/conftest.py | Modifies create_vpc_w_subnet to enable IPv6 and adjusts return value handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vshanthe
requested review from
a team,
ezilber-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Tests are passing locally. Nice work!
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great, nice work!
ezilber-akamai
added
the
testing
📝 Description
Dual stack VPC test
API spec - https://git.source.akamai.com/projects/TECHDOCS/repos/akamai-api-inventory/raw/apis/linode-api/v4/swag-logs/openapi.json?at=refs%2Fheads%2Ffeature%2FUXTW-9236-vpc-ipv6-support-tech-docs
✔️ How to Test
make test-int TEST_SUITE=vpc
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.