test: Fix create-linode-with-add-ons.spec.ts after Linode Interfaces GA#13325
Merged
bnussman-akamai merged 3 commits intoJan 27, 2026
Conversation
bnussman-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
bnussman-akamai
commented
Jan 26, 2026
Comment on lines
-30
to
-33
| // Clean up private IP value when the option is hidden | ||
| if (!shouldShowPrivateIP) { | ||
| setValue('private_ip', false); | ||
| } |
Member
Author
There was a problem hiding this comment.
Rather then setting state during render, I moved this to the onChange handler that handles when the user changes the interface generation.
On the Linode create flow, we prefer to set state eagerly in onChange handlers rather than setting state as side affects in other components
Contributor
There was a problem hiding this comment.
Thanks! Double checked and confirmed that the private IP checkbox still works as expected 👍
jdamore-linode
approved these changes
Jan 26, 2026
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @bnussman-akamai!
dmcintyr-akamai
approved these changes
Jan 27, 2026
Cloud Manager UI test results🔺 3 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/switch-linode-state.spec.ts" |
|||||||||||||||||||||||
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
create-linode-with-add-ons.spec.tsafter Linode Interfaces went GAPrivate IPaddon to be hidden, causing this test to fail.Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
create-linode-with-add-ons.spec.tspasses in CIAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅