Skip to content

[DI-29309] - Create Notification Channel label error validation#13345

Merged
santoshp210-akamai merged 5 commits into
linode:developfrom
santoshp210-akamai:feature/notification-channel-label-error-validation
Feb 2, 2026
Merged

[DI-29309] - Create Notification Channel label error validation#13345
santoshp210-akamai merged 5 commits into
linode:developfrom
santoshp210-akamai:feature/notification-channel-label-error-validation

Conversation

@santoshp210-akamai
Copy link
Copy Markdown
Contributor

Description 📝

Fix to process API errors for label field in Notification Channel Create form

Changes 🔄

List any change(s) relevant to the reviewer.

  • Rename name to label within the CreateNotificationChannelForm interface context

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

10th Feb

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • In Mock environment (Legacy MSW Handlers),
  • Click on Alerts, under Monitor
  • Enable the notificationChannels options within the aclpAlerting(CloudPulse Alerting) feature flag
  • Click on Notification Channel Tab
  • Click on Create button
  • Paste this return HttpResponse.json({errors: [{ field: 'label', reason: 'Label is already taken.'}]}, {status: 400}); in the '*/monitor/alert-channels' POST method in serverHandler.ts to simulate the error condition

Verification steps

(How to verify changes)

  • API errors with field label is visible in the form
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai santoshp210-akamai requested a review from a team as a code owner January 29, 2026 14:27
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jan 30, 2026
@linode-gh-bot
Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped35m 34s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@santoshp210-akamai
Copy link
Copy Markdown
Contributor Author

Merging this PR as the failing cypress test is not related to the PR changes.

@santoshp210-akamai santoshp210-akamai merged commit 8f07909 into linode:develop Feb 2, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants