Use a wider window to show the secrets

[UndeadDevel]

This partially fixes #1537, but while the increased width wouldn't be a problem on the NV41 AFAICT, I don't know about other machines.

I don't know what @tlaurion means with "busybox's folding", which may be a better solution.

[tlaurion]

@UndeadDevel

fold is a normally shipped Linux command which permits to spread output on multiple lines when displayed to user.

You can try it on from shell command line on common Linux OSes by default.

String="This is a really too long string of too many characters that won't display on a single line to be shown on a single line and needs to be folded to be showed correctly without hacking around"

echo "$String" | fold

Fold accepts parameters, which are different from busybox. Drop on recovery shell and try fold --help, but busybox replicates standard usage without parameters.

https://linux.die.net/man/1/fold

Standard width is 80 characters which is pretty standard and will work with older 1076 width screens and should not need to be worked around.

We cannot imply fixed width under Heads console or whiptail UX.

[UndeadDevel]

Thanks for the clarification! Changed to fold-based solution now; tested in recovery shell of NK Heads 2.1.

[JonathonHall-Purism]

Thanks for checking this out!

---

I think this needs echo -e just before fold, i.e. echo -e "$passphrases" | fold <...>. Otherwise fold could break the \n and it will break later lines incorrectly not realizing there was a line break escape (it would think it is one giant line). The '\n' is handled by whiptail currently.

Adding echo -e might compound problems if passphrases themselves contain \ (now they'll be incorrectly substituted twice) but that is already broken unfortunately, so I think echo -e is OK to make this mergeable.

I didn't test any of it, that's what it looks like from review, please correct me if I missed something 😉

---

IMO, I don't think we need to fold to WIDTH-20 (=60) columns, I think we can use all 80 columns. With 60 columns, some reasonable-length passphrases will word wrap unnecessarily.

We're spending 35 chars on LUKS Disk Recovery Key passphrase: , at 60 that leaves just 25 for the passphrase before it wraps. Most 4-word passphrases with no separators are longer than that. At width 80 we'd have 45 chars.

[UndeadDevel]

@JonathonHall-Purism Thank you for the feedback! You are right about grep needing -e; I missed that in testing at first; it's not just about backslash, but also ; chars. Regarding the WIDTH, however, I found that using 80 still hides some characters, because whiptail includes a margin around the edges, within which characters are invisible, but after some more experimentation in recovery shell I found that subtracting 5 from WIDTH will fix this issue, i.e. use all available (visible) space but not miss any characters.

I also rebased and signed off now.

[JonathonHall-Purism]

Looks great to me! @tlaurion any objections?

[tlaurion]

Calculations seem right, cannot test but should be improvement nonetheless. Merging