chore: change pk policy from packagekit to appwiz's script#37
Conversation
调整卸载脚本的polkit规则,使得符合磐石环境的需求. PMS: BUG-303279 Log:
Changelog:
* chore: change polkit rule from packagekit to appwiz's script
(PMS: BUG-303279)
Log:
deepin pr auto review代码审查意见:
综上所述,建议对上述问题进行修改和优化,以提高代码的安全性和稳定性,同时保持良好的代码质量和可维护性。 |
|
TAG Bot TAG: 0.1.14 |
Reviewer's Guide by SourceryThis pull request modifies the uninstallation process to align with the requirements of the 'Panshi' environment. It changes the policy for the uninstallation script from PackageKit to a custom script using No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @BLumia - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using
QProcess::executeinstead ofprocess.startandprocess.waitForFinishedfor simpler code. - It looks like you're calling pkexec twice in some cases - is that intentional?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
调整卸载脚本的polkit规则,使得符合磐石环境的需求.
PMS: BUG-303279
Summary by Sourcery
Modify the application uninstaller script and polkit rules to support non-root users uninstalling packages using pkexec
Bug Fixes:
Enhancements:
Chores: