Skip to content

fix: update translation files and add new languages#56

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-271635
Sep 23, 2025
Merged

fix: update translation files and add new languages#56
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-271635

Conversation

@wjyrich

@wjyrich wjyrich commented Sep 23, 2025

Copy link
Copy Markdown
Contributor
  1. Added German (de), Tamil (ta), and Turkish (tr) language support to CMakeLists.txt
  2. Updated line numbers in all translation files from line 41/43 to 75/77 to reflect source code changes
  3. Maintained existing translations while adding new language support
  4. This update ensures proper internationalization support and keeps translation files synchronized with source code changes

fix: 更新翻译文件并添加新语言支持

  1. 在 CMakeLists.txt 中添加德语、泰米尔语和土耳其语支持
  2. 将所有翻译文件中的行号从 41/43 更新为 75/77 以反映源代码变更
  3. 保持现有翻译内容同时扩展语言支持范围
  4. 此次更新确保正确的国际化支持,并使翻译文件与源代码变更保持同步

Pms: BUG-271635

Summary by Sourcery

Add support for German, Tamil, and Turkish translations and update existing translation files to match source code changes

New Features:

  • Introduce German, Tamil, and Turkish translation files

Enhancements:

  • Synchronize message location lines in all translation files from 41/43 to 75/77

Build:

  • Update CMakeLists.txt to include the new de, ta, and tr translation files

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai

sourcery-ai Bot commented Sep 23, 2025

Copy link
Copy Markdown

Reviewer's Guide

Updates translation files to match updated source line numbers and extends CMakeLists to include German, Tamil, and Turkish language support while preserving existing translations.

File-Level Changes

Change Details Files
Synchronize translation file line numbers with updated source code
  • Updated line numbers from 41 to 75 across all TS files
  • Updated line numbers from 43 to 77 across all TS files
  • Retained existing translations unchanged
translations/dde-application-wizard.ts
translations/dde-application-wizard_bo.ts
translations/dde-application-wizard_de.ts
translations/dde-application-wizard_es.ts
translations/dde-application-wizard_hu.ts
translations/dde-application-wizard_it.ts
translations/dde-application-wizard_ja.ts
translations/dde-application-wizard_ko.ts
translations/dde-application-wizard_pl.ts
translations/dde-application-wizard_pt_BR.ts
translations/dde-application-wizard_ru.ts
translations/dde-application-wizard_ta.ts
translations/dde-application-wizard_tr.ts
translations/dde-application-wizard_uk.ts
translations/dde-application-wizard_zh_CN.ts
translations/dde-application-wizard_zh_HK.ts
translations/dde-application-wizard_zh_TW.ts
Enable new language support in the build configuration
  • Added German, Tamil, and Turkish entries to TRANSLATION_FILES
  • Included new TS files in CMakeLists.txt
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

这段 diff 显示了 CMakeLists.txt 文件中翻译文件的变更,主要添加了德语(de)、泰米尔语(ta)和土耳其语(tr)的翻译文件。以下是我的审查意见:

  1. 代码质量:

    • 翻译文件的命名规范统一,使用了项目名加语言代码的格式,符合国际化(i18n)的最佳实践
    • 文件列表按字母顺序排列,便于维护和查找
  2. 代码逻辑:

    • 变更符合 CMake 的语法规范
    • 翻译文件的添加方式与现有代码保持一致
  3. 改进建议:

    • 建议在添加新语言翻译文件时,同时在代码中添加相应的翻译初始化逻辑,确保这些新语言的翻译能够被正确加载
    • 考虑添加一个 CMake 选项来控制是否包含所有翻译文件,允许用户只选择需要的语言,以减小构建产物体积
    • 建议在注释中说明项目支持的语言列表,方便开发者了解当前支持的所有语言
  4. 安全性:

    • 没有发现明显的安全问题
  5. 性能:

    • 增加翻译文件会略微增加构建时间和最终产物的大小,但对于应用程序性能影响可以忽略不计

总体而言,这个变更本身是合理且符合规范的,主要是增加了对新语言的支持。如果这是一个多语言应用程序,添加更多语言翻译是有益的。建议按照上述改进建议进行补充,以增强项目的可维护性和灵活性。

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit f84eb06 into linuxdeepin:master Sep 23, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants