chore: more logs for cooperation - #652
Merged
Merged
Conversation
Reviewer's GuideThis PR enhances traceability by injecting comprehensive debug and info logs across the cooperation modules, covering network handling, discovery, configuration I/O, sharing and transferring workflows, UI components, and plugin lifecycle events. Class diagram for updated Settings loggingclassDiagram
class SettingsPrivate {
+fromJsonFile(fileName, data)
+fromJson(json, data)
+toJson(data)
+_q_onFileChanged(filePath)
+DLOG/qInfo statements for file and JSON operations
}
class Settings {
+contains(group, key)
+groups()
+keys(group)
+keyList(group)
+value(group, key, defaultValue)
+setValue(group, key, value)
+setValueNoNotify(group, key, value)
+removeGroup(group)
+isRemovable(group, key)
+remove(group, key)
+sync()
+setAutoSync(autoSync)
+onFileChanged(filePath)
+setWatchChanges(watchChanges)
+DLOG/qInfo statements for all major actions
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @re2zero - I've reviewed your changes - here's some feedback:
- There’s a very high volume of new log statements—consider trimming redundant entries and using appropriate log levels (INFO vs DEBUG) so production logs remain concise and readable.
- A lot of these logs follow repetitive patterns—think about consolidating them into helper functions or macros for consistency and to reduce boilerplate.
- Many logs are inside performance-sensitive code paths (UI events, loops)—you may want to guard them under debug flags or remove non-critical logs to avoid runtime overhead in release builds.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a very high volume of new log statements—consider trimming redundant entries and using appropriate log levels (INFO vs DEBUG) so production logs remain concise and readable.
- A lot of these logs follow repetitive patterns—think about consolidating them into helper functions or macros for consistency and to reduce boilerplate.
- Many logs are inside performance-sensitive code paths (UI events, loops)—you may want to guard them under debug flags or remove non-critical logs to avoid runtime overhead in release builds.
## Individual Comments
### Comment 1
<location> `src/lib/cooperation/core/net/compatwrapper.cpp:113` </location>
<code_context>
// 非跨端应用无需处理
- if (appInfo.appname != ipc::CooperRegisterName)
+ if (appInfo.appname != ipc::CooperRegisterName) {
+ DLOG << "App is not CooperRegisterName, skipping";
continue;
+ }
</code_context>
<issue_to_address>
Logging every skipped app in peer list may be excessive.
For large peer lists, this could flood the logs. Consider if logging each skipped app is necessary.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
if (appInfo.appname != ipc::CooperRegisterName) {
DLOG << "App is not CooperRegisterName, skipping";
continue;
}
=======
if (appInfo.appname != ipc::CooperRegisterName) {
continue;
}
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot New tag: 1.1.11 |
Add more logs for cooperation. Log: more logs for cooperation.
lzwind
approved these changes
Jul 3, 2025
lzwind
approved these changes
Jul 3, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more logs for cooperation.
Log: more logs for cooperation.
Summary by Sourcery
Add extensive debug and informational logging across cooperation modules to enhance traceability of network operations, discovery, GUI interactions, settings management, and compatibility layers.
Enhancements: