Fix SMB mount issue: redirect to default URL after popup - #2607
Merged
Conversation
itsXuSt
approved these changes
Feb 20, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itsXuSt, Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Johnson-zs
force-pushed
the
master
branch
2 times, most recently
from
February 20, 2025 13:11
f3a90af to
12ab2d7
Compare
This commit addresses a bug where the application did not redirect to the default URL after an SMB mount operation was completed. Instead of navigating to the expected starting URL, the application remained on the previous view, leading to confusion for users. Changes made: - Implemented logic to ensure that after an SMB mount popup, the application redirects to the configured default URL. - Added checks to verify the mount operation's success before performing the redirect. - Updated relevant signal handlers to trigger the redirect appropriately. This fix enhances user experience by ensuring that the application behaves as expected after SMB operations, providing a seamless navigation flow. Log: Bug: https://pms.uniontech.com/bug-view-303643.html
This reverts commit 146ce8d.
|
TAG Bot TAG: 6.5.31 |
… cutting and pasting folders" This reverts commit e6e5f90.
6.5.31 Log: tag 6.5.31
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a bug where the application did not redirect to the default URL after an SMB mount operation was completed. Instead of navigating to the expected starting URL, the application remained on the previous view, leading to confusion for users.
Changes made:
This fix enhances user experience by ensuring that the application behaves as expected after SMB operations, providing a seamless navigation flow.
Log:
Bug: https://pms.uniontech.com/bug-view-303643.html