Skip to content

fix: still can resize when effects closed#250

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
18202781743:fix-ui
May 6, 2024
Merged

fix: still can resize when effects closed#250
BLumia merged 1 commit into
linuxdeepin:masterfrom
18202781743:fix-ui

Conversation

@18202781743

Copy link
Copy Markdown
Contributor

Limitting windowed window's size.

Issue: linuxdeepin/developer-center#7647

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • Main.qml文件中,新增的属性设置可能会导致窗口尺寸不可调整,建议评估对性能和用户体验的影响。
  • 如果DebugHelper.useRegularWindowtrue,则返回Qt.Window,这可能意味着窗口将不能被最大化或最小化,需要确认这是否符合设计要求。

合并相似的问题是否建议立即修改:

  • 是,需要确保新增的属性设置是必要的,并且不会对用户体验产生负面影响。如果新增的属性设置导致窗口尺寸不可调整,应立即评估这一改动的影响,并考虑是否有必要对DebugHelper.useRegularWindow的值为true进行特殊处理。

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这怎么看着这么奇怪(((

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, asterwyx, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit b7f2d43 into linuxdeepin:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants