Skip to content

fix: page turning is not sensitive #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsien wants to merge 1 commit into from
Closed

fix: page turning is not sensitive #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions qml/FullscreenFrame.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,15 @@ Control {
}
}
// TODO: this might not be the correct way to handle wheel
onWheel: {
onWheel: function(wheel) {
if (flipPageDelay.running) return
let xDelta = wheel.angleDelta.x / 8
let yDelta = wheel.angleDelta.y / 8
let toPage = 0; // -1 prev, +1 next, 0 don't change
if (yDelta !== 0) {
toPage = (yDelta > 0) ? -1 : 1
} else if (xDelta !== 0) {
// todo: handle natural scrolling
toPage = (xDelta > 0) ? 1 : -1
}
if (toPage < 0) {
Expand Down Expand Up @@ -204,6 +205,7 @@ Control {
visible: searchEdit.text === ""

currentIndex: indicator.currentIndex
interactive: false

// To ensure toplevelRepeater's model (page count) updated correctly
// Caution! Don't put it directly under a Repeater{}, that will prevent Connections from working
Expand Down Expand Up @@ -526,7 +528,7 @@ Control {
}

Keys.onPressed: {
if (searchEdit.focus === false && !searchEdit.text && (event.text && !"\t ".includes(event.text))) {
if (searchEdit.focus === false && !searchEdit.text && event.text) {
searchEdit.focus = true
searchEdit.text = event.text
}
Expand Down