Skip to content

fix: 无网络链接显示问题#80

Open
kingjinni wants to merge 1 commit into
linuxdeepin:masterfrom
kingjinni:bug2
Open

fix: 无网络链接显示问题#80
kingjinni wants to merge 1 commit into
linuxdeepin:masterfrom
kingjinni:bug2

Conversation

@kingjinni

Copy link
Copy Markdown
Contributor
无网络链接ip地址显示问题

Log: 无网络链接显示问题
Bug: https://pms.uniontech.com/bug-view-265185.html
Change-Id: Iadca2ad9973a5e8534b13ac2721f93b980859072

    无网络链接ip地址显示问题

Log: 无网络链接显示问题
Bug: https://pms.uniontech.com/bug-view-265185.html
Change-Id: Iadca2ad9973a5e8534b13ac2721f93b980859072
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kingjinni

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • DPrintersShowWindow::initConnections函数中,使用了lambda表达式作为槽函数的参数,但没有提供上下文信息。建议使用命名lambda表达式以提高代码可读性。
  • QNetworkConfigurationManager::configurationChanged信号的连接使用了匿名lambda表达式,这可能会导致在多个槽函数中重复使用相同的lambda表达式。建议将lambda表达式定义为类的成员函数或使用QObject::connect的第二个版本,以避免潜在的内存泄漏。
  • m_pShareIpAddr->setText(ipv4AddrList.join(" "));在网络配置非活动时,应该设置为空字符串或特定的错误消息,以提高用户体验。
  • qCDebug(COMMONMOUDLE)日志输出使用了硬编码的日志类别,建议使用常量或配置文件来管理日志类别。
  • QHostAddress ipAddress = QHostAddress();在循环中重复声明了变量,可以将其声明为局部变量以避免潜在的内存泄漏。

是否建议立即修改:

@deepin-bot

deepin-bot Bot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.15-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #83

@deepin-bot

deepin-bot Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.16-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #86

@deepin-bot

deepin-bot Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.17-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #88

@deepin-bot

deepin-bot Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.18-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #90

@deepin-bot

deepin-bot Bot commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.19-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #92

@deepin-bot

deepin-bot Bot commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 1.0.20-1+1060
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants