fix(systemd): delay startup after XSettings1 service for xsettings#220
fix(systemd): delay startup after XSettings1 service for xsettings#220Shining-N wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnsure dde-session@x11 systemd service starts only after org.deepin.dde.XSettings1.service so it picks up the latest xsettings configuration values. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Add After=org.deepin.dde.XSettings1.service to ensure kwin starts after XSettings1.service in V25, so kwin reads the latest Xsettings data from the source. Avoid parallel startup issues that could cause reading stale values and incorrect scaling. 添加 After=org.deepin.dde.XSettings1.service,使 V25 中 kwin 在 XSettings1.service 后启动,确保 kwin 读取的 Xsettings 的 数据来源(XSettings1.service)提供的是最新的。避免并行可能 引起的旧值读取,引起错误缩放等问题。 Log: 调整服务启动顺序,在 XSettings1 后启动 PMS: BUG-366239 Influence: 影响 dde-session 启动顺序
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shining-N, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/systemd/dde-session-pre.target.wants/dde-session@x11.service
+++ b/systemd/dde-session-pre.target.wants/dde-session@x11.service
@@ -7,6 +7,9 @@ ConditionEnvironment=XDG_SESSION_TYPE=%I
PartOf=dde-session-pre.target
Before=dde-session-pre.target
+# Ensure XSettings1 service is started before dde-session@x11
+After=org.deepin.dde.XSettings1.service
+
# Limit startup frequency more than the default
StartLimitIntervalSec=15s
StartLimitBurst=3 |
|
recheck |
|
TAG Bot New tag: 2.0.29 |
Add After=org.deepin.dde.XSettings1.service to ensure the service starts after XSettings1 reads the latest xsettings values.
添加 After=org.deepin.dde.XSettings1.service,确保在 XSettings1 读取最新的 xsettings 数值后启动,以获取正确的配置值。
Log: 调整服务启动顺序,在 XSettings1 后启动
PMS: BUG-349621
Influence: 影响 dde-session 启动顺序
Summary by Sourcery
Deployment: