Skip to content

fix: remove deepin prefix from Chinese translations in desktop file#129

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n
Jul 16, 2026
Merged

fix: remove deepin prefix from Chinese translations in desktop file#129
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:fix-369185-remove-deepin-from-desktop-i18n

Conversation

@add-uos

@add-uos add-uos commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。

Summary by Sourcery

Bug Fixes:

  • Correct Chinese (zh_CN/zh_HK/zh_TW) desktop file translations by removing unnecessary "深度"/"deepin"/"Deepin" prefixes from Name and Comment fields.

Remove "深度"/"deepin"/"Deepin" prefix from Name/Comment
fields in zh_CN, zh_HK, zh_TW translations.

去除 desktop 文件中 zh_CN/zh_HK/zh_TW 翻译的"深度"/"deepin"前缀。

Log: 去除desktop文件中文翻译中的深度/deepin前缀
PMS: BUG-369185
Influence: 自研应用 desktop 文件中文翻译不再包含"深度"/"deepin"品牌前缀。
@sourcery-ai

sourcery-ai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Chinese translations in the Linux desktop entry for deepin-boot-maker by removing the “深度”/“deepin”/“Deepin” brand prefixes from Name and Comment fields for zh_CN, zh_HK, and zh_TW.

File-Level Changes

Change Details Files
Normalize Chinese desktop entry translations by removing the Deepin brand prefix from Name and Comment fields.
  • Updated zh_CN Name and Comment translations to remove leading “深度”/“deepin”/“Deepin”.
  • Updated zh_HK Name and Comment translations to remove leading “深度”/“deepin”/“Deepin”.
  • Updated zh_TW Name and Comment translations to remove leading “深度”/“deepin”/“Deepin”.
  • Ensured the resulting strings remain clear and aligned with non-Chinese locales while no longer including the brand prefix.
src/app/platform/linux/deepin-boot-maker.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码修改了desktop文件的中文locale应用名称,移除了品牌前缀,逻辑正确且符合规范。
修改为纯文案调整,无安全漏洞,各维度均表现优秀,故给予满分。

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

修改位于deepin-boot-maker.desktop文件中,对Name[zh_CN]Name[zh_HK]Name[zh_TW]三个键的值进行了替换,键值对格式符合Desktop Entry规范,无语法错误。
潜在问题:无
建议:无需修改

  • 2.代码质量(良好)✓

移除了"Deepin"/"深度"前缀,使应用名称更加简洁统一,符合去品牌化或产品规范统一的需求,变更意图明确。
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

此修改仅涉及静态配置文件的字符串变更,不涉及任何运行时逻辑、算法或资源操作,对性能无任何影响。
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改为纯文案调整,不涉及任何用户输入处理、文件操作或网络通信,不存在安全风险。

  • 建议:无需修改

■ 【改进建议代码示例】

[Desktop Entry]
Name[zh_CN]=启动盘制作工具
Name[zh_HK]=開機碟製作
Name[zh_TW]=開機碟製作器

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 3ed3600 into linuxdeepin:master Jul 16, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants