Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841)#130

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Jul 17, 2026
Merged

fix: add X-Deepin-Singleton flag to desktop file (#392841)#130
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

Build:

  • Update the Deepin Boot Maker .desktop file to include the X-Deepin-Singleton flag for singleton app handling.

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Deepin boot maker desktop entry to declare the application as a singleton so that the application manager and Treeland can handle it without showing a splash screen.

File-Level Changes

Change Details Files
Declare the Deepin boot maker desktop entry as a singleton application via a new desktop key.
  • Add the X-Deepin-Singleton=true key to the desktop entry to mark the app as singleton for Deepin
  • Ensure the desktop file exposes the flag used by AM/Treeland to skip splash screens for singleton apps
src/app/platform/linux/deepin-boot-maker.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码通过新增 desktop 属性实现了应用级单实例控制,与内部单例模式配合良好
修改逻辑正确且符合 UOS 规范,无安全漏洞,质量优秀

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

deepin-boot-maker.desktop 文件中新增 X-Deepin-Singleton=true 属性,符合 Desktop Entry 规范的键值对语法。
潜在问题:无
建议:无需修改

  • 2.代码质量(优秀)✓

属性命名遵循 DDE 桌面环境的自定义扩展规范,修改意图明确,与应用内部使用的 DSingleton<BMInterface> 模式相辅相成。
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

启用单实例模式可以避免重复启动进程,减少不必要的内存和 CPU 资源消耗,对性能有正面影响。
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅涉及配置文件属性的新增,不涉及任何用户输入处理、内存操作或系统命令执行,不存在安全风险。

  • 建议:无需修改

■ 【改进建议代码示例】

# 当前代码已足够完善,无需进一步修改
[Desktop Entry]
X-Deepin-Singleton=true

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@add-uos
add-uos force-pushed the task-392841-add-x-deepin-singleton-flag branch from 0e59adb to 49be7ac Compare July 17, 2026 02:43
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit 95e6926 into linuxdeepin:master Jul 17, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants