Skip to content

chore: Update version to 6.5.59 - #312

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Jul 30, 2026
Merged

chore: Update version to 6.5.59#312
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • update version to 6.5.59

log: update version to 6.5.59

Summary by Sourcery

Bump the deepin-reader package version metadata to 6.5.59.1 in linglong configuration.

- update version to 6.5.59

log: update version to 6.5.59

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @add-uos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the application/package version metadata to 6.5.59.1 in the primary manifest and aligns the Debian changelog accordingly.

File-Level Changes

Change Details Files
Update package metadata version to 6.5.59.1 for the deepin-reader application.
  • Bump the package.version field from 6.5.58.1 to 6.5.59.1 in the main Linglong manifest.
  • Ensure version consistency for the new release in associated packaging metadata (Debian changelog entry).
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.59
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:75分

■ 【总体评价】

代码在事件处理函数中重复处理快捷键导致出现双菜单现象,核心逻辑存在缺陷
逻辑冲突导致用户体验受损,但因无安全漏洞保留及格分数

■ 【详细分析】

  • 1.语法逻辑(存在错误)✕

SheetSidebar::event() 函数中,代码通过 static_cast<QKeyEvent*>(e) 拦截了 QEvent::KeyPress 事件,并判断修饰键为 Qt::AltModifier 且按键为 Qt::Key_M 时执行菜单弹出逻辑。该处理方式与 Qt 框架或菜单组件自身的默认快捷键响应机制发生冲突,导致同一动作被触发两次,产生双菜单现象。
潜在问题:事件重复消费导致 UI 行为异常;快捷键响应逻辑分散在底层事件循环中难以维护
建议:移除 SheetSidebar::event() 中对 Alt+M 组合键的硬编码拦截与处理逻辑,将其交由系统默认行为或通过 QAction 统一管理

  • 2.代码质量(一般)✕

event() 虚函数中直接使用条件判断处理特定业务快捷键,违背了 Qt 事件过滤与快捷键管理的最佳实践。这种硬编码方式降低了代码的可读性和可扩展性,且未提供明确的注释说明为何需要在此处拦截。
潜在问题:快捷键管理分散,后续修改或禁用快捷键时容易遗漏此处逻辑
建议:使用 QShortcutQAction::setShortcut 在更高业务层级统一注册和管理快捷键,保持 event() 函数的纯净性

  • 3.代码性能(无性能问题)✓

事件处理函数内部仅包含简单的类型转换和整数比较操作,时间复杂度为 O(1),不会对主事件循环造成性能瓶颈或延迟。
建议:无需针对性能进行修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次代码修改未引入任何安全风险,不存在外部输入解析、内存越界或权限操作,攻击面为零。

  • 建议:继续保持当前安全编码标准

■ 【改进建议代码示例】

bool SheetSidebar::event(QEvent *e)
{
    // 移除对 Alt+M 的特定拦截处理,消除双菜单现象
    // 快捷键应通过 QAction 或 QShortcut 在初始化时统一注册
    return QWidget::event(e);
}

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind
lzwind merged commit a5f46eb into linuxdeepin:master Jul 30, 2026
13 checks passed
@deepin-bot

deepin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.59
  • Tag SHA: 3c254ae8ce8207a141454e5b6b32f755f640d054
  • Commit SHA: a5f46ebddaf3efa4505326c6f0dc6f486a3cdcc9
  • Tag Message:
    Release deepin-reader 6.5.59
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants