feat(tiptap): integrate minimal Tiptap editor load/save - #435
Open
dengzhongyuan365-dev wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Sorry @dengzhongyuan365-dev, your pull request is larger than the review limit of 150000 diff characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dengzhongyuan365-dev
force-pushed
the
feature/v-375-ttp022-tiptap-load-save
branch
from
July 27, 2026 09:30
76b1c5c to
cb4ef16
Compare
|
Warning
详情 {
"unset": {
"tests/src/common/ut_tiptaptempbridge.cpp": {
"b": [
"TEST_F(UT_TiptapTempBridge, UT_TiptapTempBridge_debugEnabled_unset_001)"
]
}
}
} |
First integration of the Tiptap editor runtime, validating only loading and saving the envelope content. The Summernote fallback path remains untouched and Tiptap is not enabled by default. - Add web-editor runtime entry (tiptap-editor.html/js) with Vite build config and tiptap-extensions module; commit built dist artifacts so the runtime loads offline from bundled resources - Add TiptapTempBridge (src/common) C++ bridge that loads the Tiptap editor via QWebEngineView, injects envelope content, and saves the editor.getJSON() wrapped envelope back - Add deepin-voice-note-tiptap.qrc and register the Tiptap runtime resources; wire QRC/install fallback load path - Register TiptapTempBridge in QML and adjust WebEngineView.qml - Update package.json/CMakeLists/tests CMake for the new module and resources - Add frontend round-trip unit test (npm test) and C++ GTest ut_tiptaptempbridge covering load/save envelope behavior Log: 接入最小 Tiptap 编辑器运行时,验证加载和保存 envelope.content;新增运行时入口、C++ 桥接、QRC 资源注册、QML 注册,含前端往返单测和 C++ GTest Influence: 新增 web-editor 运行时入口及打包产物、src/common/tiptaptempbridge 桥接、deepin-voice-note-tiptap.qrc 资源、QML 注册及 WebEngineView 调整;不改动 Summernote 回退路径,不默认启用 Tiptap
dengzhongyuan365-dev
force-pushed
the
feature/v-375-ttp022-tiptap-load-save
branch
from
July 27, 2026 10:00
cb4ef16 to
4e94098
Compare
deepin pr auto review★ 总体评分:92分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // src/common/tiptaptempbridge.cpp — 移除调试日志,缓存资源检查结果
QString TiptapTempBridge::tiptapHtmlPath() const
{
static const bool qrcValid = QResource(":/tiptap-editor.html").isValid();
if (qrcValid) {
return QStringLiteral("qrc:/tiptap-editor.html");
}
return QStringLiteral("file://" TIPTAP_WEB_PATH "/tiptap-editor.html");
}
void TiptapTempBridge::jsContentSaved(const QString &envelopeJson)
{
// TODO(TTP-023): persist envelope to note storage
qCDebug(dvnTiptap) << "Tiptap content saved, envelope length:" << envelopeJson.length();
}// src/common/VNoteMainManager.cpp — 移除调试日志
QObject *tiptapTempBridge_provider(QQmlEngine *engine, QJSEngine *scriptEngine)
{
Q_UNUSED(engine)
Q_UNUSED(scriptEngine)
static TiptapTempBridge instance;
return &instance;
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First integration of the Tiptap editor runtime, validating only loading and saving the envelope content. The Summernote fallback path remains untouched and Tiptap is not enabled by default.
Changes
tiptap-editor.html/tiptap-editor.js): minimal Tiptap editor with Vite build config andtiptap-extensionsmodule; builtdist/artifacts are committed so the runtime loads offline from bundled resourcessrc/common): C++ bridge that loads the Tiptap editor viaQWebEngineView, injects envelope content, and saves theeditor.getJSON()wrapped envelope backdeepin-voice-note-tiptap.qrcwith QRC/install fallback load path; registered inCMakeLists.txtTiptapTempBridgeregistered in QML,WebEngineView.qmladjustedpackage.json,CMakeLists.txt, and testsCMakeLists.txtupdated for the new module and resourcesTesting
npm test: 38 pass / 0 fail (round-trip load/save + schema/envelope validation)ut_tiptaptempbridge: 5/5 passgrep -rE "https?://" dist/— no runtime external dependencies)