Skip to content

feat: 默认桌面添加deepin-manual dde-computer deepin-home org.deepin.browser#49

Merged
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master
Sep 2, 2024
Merged

feat: 默认桌面添加deepin-manual dde-computer deepin-home org.deepin.browser#49
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master

Conversation

@Zeno-sole

Copy link
Copy Markdown
Contributor

桌面添加默认程序

Log:

@github-actions

github-actions Bot commented Aug 8, 2024

Copy link
Copy Markdown

TAG Bot

TAG: 2024.08.13
EXISTED: no
DISTRIBUTION: unstable

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/topic desktop-20240808

@deepin-ci-robot

Copy link
Copy Markdown

Add topic: desktop-20240808 successed.

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/integr-topic desktop-20240808

@deepin-ci-robot

Copy link
Copy Markdown

Integrated with pr deepin-community/Repository-Integration#1857

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

@BLumia add review

@Zeno-sole
Zeno-sole requested a review from BLumia August 8, 2024 07:36
@Zeno-sole
Zeno-sole force-pushed the master branch 2 times, most recently from cbdb0e3 to 59cae7a Compare August 8, 2024 09:32
@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/topic desktop-20240808

@deepin-ci-robot

Copy link
Copy Markdown

Add topic: desktop-20240808 successed.

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/integr-topic desktop-20240808

@deepin-ci-robot

Copy link
Copy Markdown

Integrated with pr deepin-community/Repository-Integration#1857

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/integr-topic desktop-20240808

@deepin-ci-robot

Copy link
Copy Markdown

Integrated with pr deepin-community/Repository-Integration#1857

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • deepin-default-settings.postinst脚本中,新增的ARCH=$(uname -m)变量未使用,应检查是否遗漏了相关的逻辑。
  • deepin-default-settings.postinst脚本中,新增的case语句块重复了x86_64aarch64的处理逻辑,可能存在重复代码。
  • deepin-default-settings.postinst脚本中,新增的case语句块没有处理loongarch64架构,可能需要添加相应的处理逻辑。
  • skel/Desktop/dde-computer.desktop文件中,硬编码了/usr/share/applications/dde-computer.desktop路径,这可能导致在不同环境中出现问题,建议使用相对路径或配置文件来管理这些路径。
  • skel/Desktop/deepin-manual.desktop文件中,硬编码了/usr/share/applications/deepin-manual.desktop路径,同上,建议使用相对路径或配置文件来管理这些路径。

是否建议立即修改:

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hudeng-go, Zeno-sole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants