Skip to content

fix: 通过postinst脚本动态判断版本安装desktop文件#58

Merged
xzl01 merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master
Dec 12, 2024
Merged

fix: 通过postinst脚本动态判断版本安装desktop文件#58
xzl01 merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master

Conversation

@Zeno-sole

Copy link
Copy Markdown
Contributor
   专业版不需要这些图标在桌面 仅社区版生效

Log: 解决专业版桌面环境默认多deepin-manual图标问题
pms: BUG-293199

       专业版不需要这些图标在桌面 仅社区版生效

Log:   解决专业版桌面环境默认多deepin-manual图标问题
pms: BUG-293199
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • _Generate_Icon_manual函数中,grep -iq "Community" " ];缺少一个引号,应该改为grep -iq "Community" ];
  • _Generate_Icon_deepin_browser_Generate_Icon_firefox函数中,grep -iq "Community" " ];同样缺少一个引号,应该改为grep -iq "Community" ];
  • _Generate_Icon_manual_Generate_Icon_deepin_browser_Generate_Icon_firefox函数中,ln -s命令的路径可能需要根据实际安装路径进行调整
  • 删除了skel/Desktop/deepin-manual.desktop文件,但未在代码中看到相应的处理逻辑,可能会导致问题
  • case "$ARCH" in语句中,x86_64loongarch64riscv64aarch64分支中重复调用了_Generate_Icon_manual函数,可能需要确认是否每个架构都需要调用该函数

是否建议立即修改:

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 2024.12.12
EXISTED: no
DISTRIBUTION: unstable

@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/integrate

@github-actions

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2356
PrNumber: 2356
PrBranch: auto-integration-12292981999

@xzl01

xzl01 commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

/approve

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xzl01, Zeno-sole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants