Skip to content

feat: increase inotify.max_user_instances to 1024#64

Merged
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master
Apr 8, 2025
Merged

feat: increase inotify.max_user_instances to 1024#64
Zeno-sole merged 1 commit into
linuxdeepin:masterfrom
Zeno-sole:master

Conversation

@Zeno-sole

@Zeno-sole Zeno-sole commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Applications like IDEs and file watchers may hit "Too many open files" under heavy inotify usage scenarios.

  increase inotify.max_user_instances to 1024

Log:
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

代码审查意见:

  1. .reuse/dep5 文件中的 Files 行新增了 sysctl.d/*,需要确认这是否符合项目的文件结构,以及是否所有相关的 sysctl.d 文件都已包含在内。

  2. debian/changelog 文件中新增的日志条目没有包含具体的更改内容,只是提到了增加 inotify.max_user_instances 的值。建议添加更详细的更改描述,以便于其他开发者理解这次提交的目的。

  3. sysctl.d/00-deepin.conf 文件中新增了一行配置 fs.inotify.max_user_instances=1024,需要确认这个更改是否经过充分测试,并且不会对系统性能产生负面影响。

  4. 所有新增的配置项都应该有相应的注释说明其用途和可能的影响,以便于维护者理解这些更改的目的。

  5. 如果 inotify.max_user_instances 的值从默认值增加,需要确保系统有足够的资源来支持这个更改,并且不会导致系统资源耗尽。

  6. 提交日志中的日期格式应该统一,建议使用 YYYY-MM-DD 格式,而不是 Mon, DD MMM YYYY HH:MM:SS +0000

  7. 确保所有新增的配置项都遵循项目的代码风格和格式规范,以保持代码的一致性和可读性。

  8. 如果这个更改会影响其他依赖这个包的系统,应该在提交日志中说明,以便其他开发者注意。

  9. 如果这个更改涉及到安全性的提升,应该在提交日志中特别说明,并确保相关的安全测试已经通过。

  10. 如果这个更改涉及到许可证的变更,需要确保新的许可证与项目的整体许可证策略一致,并且所有相关的文件都已经更新了正确的许可证信息。

@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown

TAG Bot

TAG: 2025.04.07
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BLumia, Zeno-sole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Zeno-sole
Zeno-sole merged commit 7579011 into linuxdeepin:master Apr 8, 2025
@Zeno-sole

Copy link
Copy Markdown
Contributor Author

/integrate

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2733
PrNumber: 2733
PrBranch: auto-integration-14323707823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants