Skip to content

chore: update shortcuts on Desktop after system installation#67

Merged
BLumia merged 2 commits into
linuxdeepin:masterfrom
BLumia:pms-task-377707
Jun 18, 2025
Merged

chore: update shortcuts on Desktop after system installation#67
BLumia merged 2 commits into
linuxdeepin:masterfrom
BLumia:pms-task-377707

Conversation

@BLumia

@BLumia BLumia commented Jun 17, 2025

Copy link
Copy Markdown
Member

更新安装完系统后,默认桌面上包含的快捷方式.

变更:

  1. 桌面不再默认包含浏览器的快捷方式
  2. 添加回收站快捷方式

@BLumia
BLumia requested review from Zeno-sole and xzl01 June 17, 2025 06:15
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia
Once this PR has been reviewed and has the lgtm label, please assign zeno-sole for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 2025.06.17
EXISTED: no
DISTRIBUTION: unstable

BLumia added 2 commits June 17, 2025 14:28
更新安装完系统后,默认桌面上包含的快捷方式.

变更:

1. 桌面不再默认包含浏览器的快捷方式
2. 添加回收站快捷方式

PMS: TASK-377707
Log:
  * adjust default shortcuts on desktop.

Log:
@deepin-bot

deepin-bot Bot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 2025.06.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #66

@BLumia
BLumia force-pushed the pms-task-377707 branch from 154cf72 to 38aae48 Compare June 17, 2025 06:29
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

代码审查意见:

  1. Changelog 文件格式

    • debian/changelog 文件中,新增的日志条目缺少具体的更改描述,应该详细说明调整默认快捷方式的具体内容。
  2. 脚本注释

    • debian/deepin-default-settings.postinst 脚本中的注释应该更加详细,解释每一步的目的和操作。
  3. 脚本逻辑

    • _Generate_Icon_deepin_browser_Generate_Icon_firefox 函数中,grep -iq "Community" 后面缺少了 ],可能会导致语法错误。
    • _Generate_Icon_deepin_browser_Generate_Icon_firefox 函数中,grep -iq "Community" " ]; then 应该改为 grep -iq "Community" ]; then
  4. 代码重复

    • _Generate_Icon_deepin_browser_Generate_Icon_firefox 函数中的逻辑几乎相同,可以考虑合并为一个函数,减少代码重复。
  5. 文件权限

    • 新增的 dde-trash.desktop 文件应该设置正确的权限,以确保只有授权用户可以访问。
  6. 脚本健壮性

    • debian/deepin-default-settings.postinst 脚本中,sed 命令没有检查是否成功执行,可能会导致未预期的行为。
  7. 环境变量

    • debian/deepin-default-settings.postinst 脚本中,$ARCH 变量在使用前应该检查是否已定义,以避免潜在的脚本错误。
  8. 代码风格

    • 脚本中的空行和缩进应该保持一致,以提高代码的可读性。
  9. 错误处理

    • debian/deepin-default-settings.postinst 脚本中,ln -s 命令应该检查链接是否成功创建,以避免潜在的问题。
  10. 国际化

    • 如果 deepin-default-settings 支持多语言,应该确保所有用户界面文本都进行了适当的翻译。

综上所述,代码需要改进的地方主要集中在逻辑错误、代码重复、错误处理、代码风格和国际化等方面。

@Zeno-sole

Copy link
Copy Markdown
Contributor

/integrate

@github-actions

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2925
PrNumber: 2925
PrBranch: auto-integration-15700304686

@BLumia
BLumia merged commit 527b08f into linuxdeepin:master Jun 18, 2025
14 checks passed
@BLumia
BLumia deleted the pms-task-377707 branch June 18, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants