Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

sync: from linuxdeepin/dtkdeclarative - #239

Merged
18202781743 merged 1 commit into
masterfrom
sync-pr-469-nosync
Mar 4, 2025
Merged

sync: from linuxdeepin/dtkdeclarative#239
18202781743 merged 1 commit into
masterfrom
sync-pr-469-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#469

Summary by Sourcery

Bug Fixes:

  • Fixes a crash in DSGBlendNode::render that could occur when the referred blur behind item is destroyed by a Loader by adding a check to ensure the item has a valid window before rendering.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot

deepin-bot Bot commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 6.0.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #240

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#469
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

关键摘要:

  • render函数中增加了对m_item->window()的检查,这是一个好的做法,可以防止在m_item无效时调用window()方法导致的崩溃。

是否建议立即修改:

  • 否,当前提交的修改是合理的,没有发现需要立即修改的问题。但是,建议进行进一步的代码审查以确保没有其他潜在的问题。

@18202781743
18202781743 merged commit b2d277d into master Mar 4, 2025
@18202781743
18202781743 deleted the sync-pr-469-nosync branch March 4, 2025 05:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants