feat: dplugin by black-desk · Pull Request #262 · linuxdeepin/dtkcore

black-desk · 2023-02-09T10:22:13Z

build: clean cmakelist
feat: start impl dplugin

deepin-bot · 2023-02-09T10:26:43Z

Doc Check bot
🟡 some documents missing!

File	Line	Symbol
include/util/dplugin.h	25	const QScopedPointer Dtk::Core::DPlugin::library
include/util/dplugin.h	23	static QList< std::shared_ptr< DPlugin > > Dtk::Core::DPlugin::listPlugins
include/util/dplugin.h	26	QString Dtk::Core::DPlugin::name
include/util/dplugin.h	18	Dtk::Core::DPlugin

black-desk · 2023-02-16T13:44:06Z

@kegechen @zccrs @Groveer @justforlxz

这边希望给 DTK 添加一个通用的插件寻找机制, 方便需要使用插件来加载可选功能的应用编写.

这个机制目前设计如下:

应用会从 QT 给的 AppDataLocation 目录下的 plugins 文件夹中寻找配置文件. 配置文件中记录该插件的名称版本和库名(也可以是绝对路径). 这些信息被用来初始化一个 QLibrary 对象. 需要加载插件的应用使用这个对象来工作.

这种设计参考了 chrome 以及 fcitx 的设计, 这两个项目都没有采取固定位置直接放置 so 库的做法, 而是采取了如此通过配置文件来寻找真正要使用的插件的做法.

由于 AppDataLocation 尊重 XDG_DATA_DIR 环境变量¹, 如此设计对于需要更改插件实际存放位置的情况来说比较友好.

https://github.com/qt/qtbase/blob/d7e8d5bb1b5a9c4b21a3d824780c672eaf4e56b1/src/corelib/io/qstandardpaths_unix.cpp#L374 ↩

github-actions · 2023-02-16T15:31:55Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

zccrs · 2023-02-20T03:07:13Z

@kegechen @zccrs @Groveer @justforlxz

这边希望给 DTK 添加一个通用的插件寻找机制, 方便需要使用插件来加载可选功能的应用编写.

这个机制目前设计如下:

应用会从 QT 给的 AppDataLocation 目录下的 plugins 文件夹中寻找配置文件. 配置文件中记录该插件的名称版本和库名(也可以是绝对路径). 这些信息被用来初始化一个 QLibrary 对象. 需要加载插件的应用使用这个对象来工作.

这种设计参考了 chrome 以及 fcitx 的设计, 这两个项目都没有采取固定位置直接放置 so 库的做法, 而是采取了如此通过配置文件来寻找真正要使用的插件的做法.

由于 AppDataLocation 尊重 XDG_DATA_DIR 环境变量1, 如此设计对于需要更改插件实际存放位置的情况来说比较友好.

Footnotes

https://github.com/qt/qtbase/blob/d7e8d5bb1b5a9c4b21a3d824780c672eaf4e56b1/src/corelib/io/qstandardpaths_unix.cpp#L374 leftwards_arrow_with_hook

为什么不直接使用 QPluginLoader 呢

black-desk · 2023-02-20T07:45:52Z

为什么不直接使用 QPluginLoader 呢

重点并不在于加载库的具体过程，而在于插件加载的过程需要：

尊重XDG_DATA_DIRS环境变量
方便具体的库位置移动

这对nix/flatpak以及玲珑类的打包方式都很有意义。

asterwyx · 2023-02-23T05:46:48Z

-    ${CMAKE_CURRENT_LIST_DIR}/dvtablehook.cpp 
-    ${CMAKE_CURRENT_LIST_DIR}/dthreadutils.cpp 
-    ${CMAKE_CURRENT_LIST_DIR}/dtimedloop.cpp
+  set(UTILS_SOURCE ${UTILS_SOURCE}


I recommend using list(APPEND).

asterwyx · 2023-02-23T05:48:39Z

+
+class DPluginPrivate;
+
+class DPlugin : public QObject


Should DPlugin derive from DObject? If yes, it's better to use D_DECLARE_PRIVATE. And remember to make DPluginPrivate derive from DObjectPrivate.

No logical change.

This commit implement DPlugin class. Documentation will be added later.

black-desk · 2023-03-29T08:05:06Z

想了想好像解决不了插件里面又加载了其他的so的问题, 我再考虑考虑怎么解决这个先挂着

kegechen · 2023-07-17T01:15:27Z

+QList<std::shared_ptr<DPlugin>> DPluginPrivate::searchPluginsInPath(const QString &pluginDirPath)
+{
+    auto const pluginDir = QDir(pluginDirPath);
+    auto const entryList = pluginDir.entryList();


可以通过 QDir::Filter::Files 过滤一下，下面就不用判断是不是文件了

kegechen · 2023-07-17T01:19:18Z

+    }
+
+    auto config = jsonDoc.object();
+    if (!DPluginPrivate::configCompatible(config["pluginConfigVersion"])) {


json 的示例文件可以在注释或者什么地方提供一下。

既然已知是 plugin 的配置文件，是不是 json 中的 key 可以去掉 plugin 的前缀

kegechen · 2023-07-17T01:21:18Z

+    return plugins;
+}
+
+QList<std::shared_ptr<DPlugin>> DPluginPrivate::searchPluginsInPath(const QString &pluginDirPath)


Suggested change

QList<std::shared_ptr<DPlugin>> DPluginPrivate::searchPluginsInPath(const QString &pluginDirPath)

QList<std::shared_ptr<DPlugin>> DPluginPrivate::load(const QString &pluginDirPath)

deepin-bot · 2024-01-09T06:23:58Z

TAG Bot

New tag: 5.6.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #399

deepin-bot · 2024-01-12T06:21:22Z

TAG Bot

New tag: 5.6.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #400

deepin-bot · 2024-03-11T07:32:52Z

TAG Bot

New tag: 5.6.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #406

deepin-bot · 2024-03-27T06:25:01Z

TAG Bot

New tag: 5.6.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #407

deepin-bot · 2024-04-23T01:24:28Z

TAG Bot

New tag: 5.6.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #410

deepin-bot · 2024-04-30T07:40:58Z

TAG Bot

New tag: 5.6.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #411

deepin-bot · 2024-05-16T02:28:33Z

TAG Bot

New tag: 5.6.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #415

deepin-bot · 2024-05-31T07:28:21Z

TAG Bot

New tag: 5.6.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #424

black-desk force-pushed the black-desk/dev/dplugin branch 5 times, most recently from f18bad2 to 1a02895 Compare February 16, 2023 13:25

black-desk force-pushed the black-desk/dev/dplugin branch from 53937c9 to 1c26bc7 Compare February 16, 2023 15:33

asterwyx requested changes Feb 23, 2023

View reviewed changes

black-desk added 2 commits March 6, 2023 16:27

build: clean cmakelist

9299e43

No logical change.

feat: start implement DPlugin

d2cc763

This commit implement DPlugin class. Documentation will be added later.

black-desk force-pushed the black-desk/dev/dplugin branch from 1c26bc7 to d2cc763 Compare March 6, 2023 08:27

kegechen reviewed Jul 17, 2023

View reviewed changes

black-desk closed this Jun 1, 2024

	QList<std::shared_ptr<DPlugin>> DPluginPrivate::searchPluginsInPath(const QString &pluginDirPath)
	QList<std::shared_ptr<DPlugin>> DPluginPrivate::load(const QString &pluginDirPath)

Uh oh!

Conversation

black-desk commented Feb 9, 2023

Uh oh!

deepin-bot Bot commented Feb 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

black-desk commented Feb 16, 2023

Footnotes

Uh oh!

github-actions Bot commented Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zccrs commented Feb 20, 2023

Footnotes

Uh oh!

black-desk commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asterwyx Feb 23, 2023

Choose a reason for hiding this comment

Uh oh!

asterwyx Feb 23, 2023

Choose a reason for hiding this comment

Uh oh!

black-desk commented Mar 29, 2023

Uh oh!

kegechen Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kegechen Jul 17, 2023

Choose a reason for hiding this comment

Uh oh!

kegechen Jul 17, 2023

Choose a reason for hiding this comment

Uh oh!

deepin-bot Bot commented Jan 9, 2024

Uh oh!

deepin-bot Bot commented Jan 12, 2024

Uh oh!

deepin-bot Bot commented Mar 11, 2024

Uh oh!

deepin-bot Bot commented Mar 27, 2024

Uh oh!

deepin-bot Bot commented Apr 23, 2024

Uh oh!

deepin-bot Bot commented Apr 30, 2024

Uh oh!

deepin-bot Bot commented May 16, 2024

Uh oh!

deepin-bot Bot commented May 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deepin-bot Bot commented Feb 9, 2023 •

edited

Loading

github-actions Bot commented Feb 16, 2023 •

edited

Loading

black-desk commented Feb 20, 2023 •

edited

Loading

kegechen Jul 17, 2023 •

edited

Loading