Skip to content

fix: lossing value when save DConfig #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Mar 27, 2024
Merged

fix: lossing value when save DConfig #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/dconfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,20 +398,29 @@ class Q_DECL_HIDDEN DBusBackend : public DConfigBackend
auto reply = config->isDefaultValue(key);
reply.waitForFinished();
if (reply.isError()) {
qWarning() << "Wrong when calling `isDefaultValue`, key:" << key << ", error message:" << reply.error().message();
qWarning() << "Failed to call `isDefaultValue`, key:" << key
<< ", error message:" << reply.error().message();
return false;
}
return reply.value();
}

virtual void setValue(const QString &key, const QVariant &value) override
{
config->setValue(key, QDBusVariant(value));
auto reply = config->setValue(key, QDBusVariant(value));
reply.waitForFinished();
if (reply.isError())
qCWarning(cfLog) << "Failed to setValue for the key:" << key
<< ", error message:" << reply.error();
}

virtual void reset(const QString &key) override
{
config->reset(key);
auto reply = config->reset(key);
reply.waitForFinished();
if (reply.isError())
qCWarning(cfLog) << "Failed to reset for the key:" << key
<< ", error message:" << reply.error();
}

virtual QString name() const override
Expand Down