Skip to content

fix: standardize version formatting in spec - #484

Closed
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master
Closed

fix: standardize version formatting in spec#484
18202781743 wants to merge 1 commit into
linuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743

Copy link
Copy Markdown
Contributor
  1. Aligned version and release fields with consistent spacing
  2. Added %{?dist} macro to release field for proper RPM dist tag
    handling
  3. Maintained same version number (5.7.17) while improving spec file
    formatting

fix: 标准化 spec 中的版本格式

  1. 统一版本和发布字段的间距格式
  2. 在发布字段中添加 %{?dist} 宏以正确处理 RPM 发行标签
  3. 保持相同版本号 (5.7.17) 的同时改进 spec 文件格式

mhduiy
mhduiy previously approved these changes Jun 19, 2025
1. Deleted conanfile.py and linglong.yaml as they were outdated build
configuration files
2. Removed these files from .syncexclude since they no longer exist
3. Cleaned up rpm/dtkcore.spec formatting (spacing and dist tag
addition)
4. These changes reflect the project's move away from Conan and Linglong
build systems

chore: 移除过时的构建配置文件

1. 删除了conanfile.py和linglong.yaml这两个过时的构建配置文件
2. 从.syncexclude中移除了这些已不存在的文件
3. 清理了rpm/dtkcore.spec的格式(间距和添加dist标签)
4. 这些变更反映了项目不再使用Conan和Linglong构建系统
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 19, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#484
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

代码审查意见:

  1. .syncexclude 文件修改:

    • 移除了 linglong.yamlconanfile.py 文件,确认这些文件是否确实不再需要,如果需要保留,请提供相应的理由。
  2. conanfile.py 文件删除:

    • conanfile.py 文件被删除,需要确认这是否是预期的操作。如果删除是必要的,请确保相关的依赖和构建流程已经更新。
  3. linglong.yaml 文件删除:

    • linglong.yaml 文件被删除,需要确认这是否是预期的操作。如果删除是必要的,请确保相关的构建和打包流程已经更新。
  4. rpm/dtkcore.spec 文件修改:

    • VersionRelease 字段格式已更改,添加了 %{?dist},这通常用于区分不同的发行版。确认这是否符合项目的发布策略。
  5. 代码风格和格式:

    • conanfile.py 中,注释掉的代码应该被删除,以保持代码的整洁。
    • conanfile.py 中的一些变量和路径拼接可以简化,例如 outdirmkspecsdir 等。
  6. 安全性:

    • 确保所有外部依赖和库都是安全的,特别是那些从第三方获取的依赖。
  7. 性能:

    • 如果 conanfile.py 中有大量的文件复制操作,考虑是否有优化的空间,例如使用并发复制。
  8. 代码质量:

    • conanfile.py 中的一些命令拼接可以封装成一个函数,以提高代码的可读性和可维护性。
    • conanfile.py 中的异常处理应该更详细,不仅仅是打印一条消息,应该有更明确的错误处理机制。
  9. 文档和注释:

    • conanfile.py 中缺少对一些关键步骤的注释,建议添加必要的注释以提高代码的可读性。
  10. 版本控制:

    • 确保所有删除的文件和代码都有相应的版本控制记录,以便于回溯和问题追踪。

总体来说,这些修改看起来是合理的,但需要确保每个删除和修改都有充分的理由,并且相关的依赖和构建流程都已经更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants