Skip to content

fix: build error on Windows#573

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2
Jul 17, 2026
Merged

fix: build error on Windows#573
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
kt286:fix/build_on_msys2

Conversation

@kt286

@kt286 kt286 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

fix build error on Windows

sourcery-ai[bot]
sourcery-ai Bot reviewed Jul 15, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

deepin-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR. 😃

@deepin-ci-robot

deepin-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BLumia
BLumia previously approved these changes Jul 16, 2026
View reviewed changes

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @18202781743 也瞅瞅？

@BLumia
BLumia requested a review from 18202781743 July 16, 2026 02:55
18202781743
18202781743 previously approved these changes Jul 16, 2026
View reviewed changes
@18202781743

18202781743 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

dtk5的没编译过，
image

@kt286
kt286 dismissed stale reviews from 18202781743 and BLumia via e3d8097 July 16, 2026 04:00
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from acacd4a to e3d8097 Compare July 16, 2026 04:00
@kt286
kt286 requested review from 18202781743 and BLumia July 16, 2026 04:03
18202781743
18202781743 reviewed Jul 16, 2026
View reviewed changes
Comment thread src/CMakeLists.txt
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from 537e373 to 5acc872 Compare July 16, 2026 08:46
18202781743
18202781743 previously approved these changes Jul 16, 2026
View reviewed changes
@18202781743

18202781743 commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

copyright更新一下，
image

@deepin-bot

deepin-bot Bot commented Jul 16, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

TAG Bot

TAG: 6.7.46
EXISTED: yes
DISTRIBUTION: unstable

@kt286
kt286 force-pushed the fix/build_on_msys2 branch 2 times, most recently from 6f09c13 to ecfa1b4 Compare July 16, 2026 14:06
@18202781743

18202781743 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

只改你修改的文件的copyright，其它的不用改，

@kt286
fix: build error on Windows
10c4a15 
fix build error on Windows
@kt286
kt286 force-pushed the fix/build_on_msys2 branch from ecfa1b4 to 10c4a15 Compare July 16, 2026 14:16
@kt286

kt286 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

只改你修改的文件的copyright，其它的不用改，

好久没给 deepin 提 PR 了，不太懂现在的规则了

@deepin-ci-robot

deepin-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743

18202781743 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 14054a8 into linuxdeepin:master Jul 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@18202781743 18202781743 18202781743 approved these changes
@BLumia BLumia Awaiting requested review from BLumia

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kt286 @deepin-ci-robot @18202781743 @BLumia