Skip to content

feat: support to override for external caller - #274

Merged
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:override-blur
Jan 16, 2024
Merged

feat: support to override for external caller#274
18202781743 merged 1 commit into
linuxdeepin:masterfrom
18202781743:override-blur

Conversation

@18202781743

@18202781743 18202781743 commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Add a InWindowBlur to replace original InWindowBlurImpl.
external caller can intercept it by QQmlAbstractUrlInterceptor. e.g:

class DtkInterceptor : public QQmlAbstractUrlInterceptor
{
public:
    QUrl intercept(const QUrl &path, DataType type)
    {
        if (path.path().endsWith("overridable/InWindowBlur.qml"))
            return "MyBlur.qml";

        return path;
    }
};

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 10, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
6215750 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
@deepin-ci-robot deepin-ci-robot mentioned this pull request Jan 10, 2024
Merged
@deepin-bot

deepin-bot Bot commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
src/private/dquickinwindowblur_p.h 34 Dtk::Quick::DQuickInWindowBlur::DQuickInWindowBlur
src/private/dquickinwindowblur_p.h 35 Dtk::Quick::DQuickInWindowBlur::~DQuickInWindowBlur
src/private/dquickinwindowblur_p.h 37 qreal Dtk::Quick::DQuickInWindowBlur::radius
src/private/dquickinwindowblur_p.h 38 void Dtk::Quick::DQuickInWindowBlur::setRadius
src/private/dquickinwindowblur_p.h 40 bool Dtk::Quick::DQuickInWindowBlur::offscreen

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 10, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
b744924 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 10, 2024
@18202781743
feat: override dtk's blur
a4130c4 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
@18202781743 18202781743 mentioned this pull request Jan 10, 2024
Merged
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 10, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
02f462c 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 10, 2024
@18202781743
feat: override dtk's blur
27d44a8 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 12, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
96822ff 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
@deepin-bot

deepin-bot Bot commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #273

18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 12, 2024
@18202781743
feat: override dtk's blur
5585f38 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
zccrs
zccrs requested changes Jan 15, 2024
View reviewed changes
Comment thread qt6/src/qml/overridable/InWindowBlur.qml Outdated
Comment thread qt6/src/qml/overridable/InWindowBlur.qml Outdated
@18202781743
18202781743 force-pushed the override-blur branch 2 times, most recently from 303e566 to 2bcb4e7 Compare January 16, 2024 01:43
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 16, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
2f6171e 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 16, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
ff7b53d 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
@18202781743
feat: support to override for external caller
409b337 
  Add a InWindowBlur to replace original InWindowBlurImpl.
external caller can intercept it by `QQmlAbstractUrlInterceptor`.
e.g:
```
class DtkInterceptor : public QQmlAbstractUrlInterceptor
{
public:
    QUrl intercept(const QUrl &path, DataType type)
    {
        if (path.path().endsWith("overridable/InWindowBlur.qml"))
            return "MyBlur.qml";

        return path;
    }
};
```
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 16, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkdeclarative
ea27669 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 16, 2024
@18202781743
feat: override dtk's blur
20a93cd 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
@18202781743
18202781743 requested a review from zccrs January 16, 2024 01:55
18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 16, 2024
@18202781743
feat: override dtk's blur
645c2a9 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
@deepin-ci-robot

deepin-ci-robot commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

18202781743 added a commit to 18202781743/treeland that referenced this pull request Jan 16, 2024
@18202781743
feat: override dtk's blur
e21c9cc 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
@18202781743
18202781743 merged commit 939f0f3 into linuxdeepin:master Jan 16, 2024
zccrs pushed a commit to linuxdeepin/treeland that referenced this pull request Jan 16, 2024
@18202781743 @zccrs
feat: override dtk's blur
5c484a0 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jan 16, 2024
@deepin-ci-robot @18202781743
sync: from linuxdeepin/dtkdeclarative
74c6325 
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#274
ZhongYic00 pushed a commit to ZhongYic00/treeland that referenced this pull request Mar 4, 2024
@18202781743 @zccrs
feat: override dtk's blur
80f00f0 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
zccrs pushed a commit to zccrs/treeland that referenced this pull request Jun 9, 2026
@18202781743 @zccrs
feat: override dtk's blur
7a6e599 
  it exists some bug in treeland, so we override dtkdeclarative's
blur.
  It depends on linuxdeepin/dtkdeclarative#274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zccrs zccrs zccrs approved these changes
@kegechen kegechen Awaiting requested review from kegechen
@zzxyb zzxyb Awaiting requested review from zzxyb
@FeiWang1119 FeiWang1119 Awaiting requested review from FeiWang1119

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@18202781743 @deepin-ci-robot @zccrs