feat: support base64 format for icons#286
Merged
Merged
Conversation
We don't use ImageProvider to support base64 image, although it can use Qt's pixmap cache, the cache will use url as a part of the cache key.
18202781743
requested review from
BLumia,
FeiWang1119,
asterwyx,
kegechen and
zccrs
January 23, 2024 10:08
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jan 23, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#286
Contributor
|
Doc Check bot
|
BLumia
approved these changes
Jan 24, 2024
asterwyx
approved these changes
Jan 24, 2024
Contributor
Author
|
/check obs |
Contributor
|
Deepin Obs Bot |
zccrs
approved these changes
Jan 29, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, asterwyx, BLumia, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Jan 29, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use ImageProvider to support base64 image, although it can
use Qt's pixmap cache, the cache will use url as a part of the cache key.