feat: add corners for BoxShadow - #294
Merged
Merged
Conversation
18202781743
requested review from
BLumia,
FeiWang1119,
kegechen,
zccrs and
zzxyb
March 8, 2024 08:19
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
Contributor
|
Doc Check bot
|
BLumia
previously approved these changes
Mar 10, 2024
zccrs
requested changes
Mar 11, 2024
18202781743
force-pushed
the
shadow-corners
branch
from
March 11, 2024 04:25
cc083de to
d075f53
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 11, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
18202781743
force-pushed
the
shadow-corners
branch
from
March 11, 2024 04:29
d075f53 to
20d2aba
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 11, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
18202781743
force-pushed
the
shadow-corners
branch
from
March 11, 2024 05:16
20d2aba to
86bc4b3
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 11, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
Contributor
|
TAG Bot New tag: 5.6.25 |
zccrs
requested changes
Mar 11, 2024
We need to set Corners for shadows, which is same as DRoundRectangle. TODO: support to set Corners for Shadow image, and updating it's cache png.
18202781743
force-pushed
the
shadow-corners
branch
from
March 11, 2024 11:43
86bc4b3 to
b420798
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 11, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
zccrs
approved these changes
Mar 12, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Mar 12, 2024
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#294
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to set Corners for shadows, which is same as DRoundRectangle.
TODO: support to set Corners for Shadow image, and updating it's cache png.