Skip to content

chore: adjust the animation for menu - #365

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:menu
Aug 8, 2024
Merged

chore: adjust the animation for menu#365
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:menu

Conversation

@FeiWang1119

Copy link
Copy Markdown

add the enter transition animation

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#365
@deepin-bot

deepin-bot Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#365
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

add the enter transition animation

Log:
@kegechen
kegechen merged commit 2578119 into linuxdeepin:dev/animation Aug 8, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#365
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ArrowListView.qml中移除了highlight组件,可能会影响用户界面的样式和功能。
  • Menu.qml中添加了highlight组件,但未提供相应的属性说明和样式预览。
  • MenuItem.qml中添加了Behavior来控制图标颜色,但没有提供上下文说明为什么需要这样的功能。
  • DQuickIconLabelsetColor方法中添加了Q_EMIT colorChanged(color);,但没有提供上下文说明为什么需要这样做。

是否建议立即修改:

  • 是,需要提供更多的上下文信息和文档说明,以便其他开发者理解这些更改的影响。
  • 是,应该评估ArrowListView.qml中移除highlight组件的影响,并考虑是否需要恢复或提供替代的解决方案。
  • 是,应该提供Menu.qmlhighlight组件的属性说明和样式预览,以便其他开发者能够更好地理解和使用这个新添加的组件。
  • 是,应该提供MenuItem.qml中添加Behavior来控制图标颜色的上下文说明,以便其他开发者理解这一变更的目的。
  • 是,应该提供DQuickIconLabelsetColor方法中添加Q_EMIT colorChanged(color);的上下文说明,以便其他开发者理解这一变更的目的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants