Skip to content

chore: adjust the animation for FloatingMessage - #366

Merged
FeiWang1119 merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:message
Aug 7, 2024
Merged

chore: adjust the animation for FloatingMessage#366
FeiWang1119 merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:message

Conversation

@FeiWang1119

Copy link
Copy Markdown

add the closing animation for the message which can be closed automatically

Log:

@FeiWang1119
FeiWang1119 requested a review from 18202781743 July 25, 2024 13:26
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
@deepin-bot

deepin-bot Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
src/private/dmessagemanager_p.h 27 Dtk::Quick::FloatingMessageContainer::FloatingMessageContainer
src/private/dmessagemanager_p.h 29 QVariant Dtk::Quick::FloatingMessageContainer::message
src/private/dmessagemanager_p.h 30 void Dtk::Quick::FloatingMessageContainer::setMessage
src/private/dmessagemanager_p.h 40 Q_SLOT Dtk::Quick::FloatingMessageContainer::pad0
src/private/dmessagemanager_p.h 44 void Dtk::Quick::FloatingMessageContainer::messageChanged
src/private/dmessagemanager_p.h 45 void Dtk::Quick::FloatingMessageContainer::durationChanged
src/private/dmessagemanager_p.h 46 void Dtk::Quick::FloatingMessageContainer::delayClose
src/private/dmessagemanager_p.h 58 Dtk::Quick::MessageManager

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 26, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 31, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 31, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
@FeiWang1119
FeiWang1119 requested a review from kegechen August 2, 2024 05:39
Comment thread src/private/dmessagemanager_p.h
Comment thread qt6/src/qml/FloatingMessage.qml Outdated
Comment thread src/private/dmessagemanager.cpp
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

add the animation for ProgressBar

Log:
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • FloatingMessageContainer类中,setImmediateClose方法被添加,但未在类定义中看到对应的方法声明。
  • immediateClose属性的getter和setter方法被添加,但在类定义中未看到该属性的声明。
  • delayClose信号在类中声明,但在类定义中未看到该信号的连接或触发操作。
  • timerEvent方法中增加了对immediateClose属性的检查,但没有处理delayClose信号的情况。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#366
@FeiWang1119
FeiWang1119 merged commit 58b51ae into linuxdeepin:dev/animation Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants