Skip to content

feat: add ListView to support hover animations - #367

Merged
kegechen merged 3 commits into
linuxdeepin:dev/animationfrom
kegechen:listview_hover
Aug 8, 2024
Merged

feat: add ListView to support hover animations#367
kegechen merged 3 commits into
linuxdeepin:dev/animationfrom
kegechen:listview_hover

Conversation

@kegechen

@kegechen kegechen commented Jul 30, 2024

Copy link
Copy Markdown
Contributor
  • item enter / leave animation
  • item hover changed animation
  • fix backgroundVisible not work

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
@kegechen
kegechen requested a review from 18202781743 July 30, 2024 03:31
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 31, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 2, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 2, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
- item enter / leave animation
- item hover changed animation
- fix backgroundVisible not work
listview check animation(dci)
add DragItemsImage to Generate a thumbnail of dragged items
@kegechen
kegechen merged commit 5c946f9 into linuxdeepin:dev/animation Aug 8, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#367
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ListView组件中,新增了DragItemsImage组件用于拖拽功能,但未提供拖拽图标item_checked.dciitem_unchecked.dci的来源说明。
  • ListView组件中的hideTimer定时器用于控制背景项的显示和隐藏,但未提供hideTimer的触发条件说明。
  • ListView组件中的onHoveredChangedonCheckedChanged方法在处理hoveredItemcheckedItems时,直接操作了外部变量,可能导致状态不一致。
  • ListView组件中的ItemDelegate状态转换和过渡动画未提供详细说明,可能需要进一步优化以提高性能。

是否建议立即修改:

  • 确保item_checked.dciitem_unchecked.dci的来源正确,以便在拖拽功能中使用。
  • 明确hideTimer的触发条件,避免潜在的逻辑错误。
  • 重新审视onHoveredChangedonCheckedChanged方法,确保它们的状态管理逻辑清晰且正确。
  • 优化ItemDelegate的状态转换和过渡动画,以提高UI的流畅度和性能。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants