Skip to content

chore: add the animation for ProgressBar - #368

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:progressbar
Aug 8, 2024
Merged

chore: add the animation for ProgressBar#368
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:progressbar

Conversation

@FeiWang1119

Copy link
Copy Markdown

add the animation for ProgressBar

Log:

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
@deepin-bot

deepin-bot Bot commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jul 30, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
@FeiWang1119
FeiWang1119 requested a review from kegechen August 2, 2024 05:39
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
@FeiWang1119
FeiWang1119 requested a review from 18202781743 August 7, 2024 08:20
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
add the animation for ProgressBar

Log:
@kegechen
kegechen merged commit 51dd905 into linuxdeepin:dev/animation Aug 8, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#368
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • Gradient对象中,GradientStop的位置属性从1 - 1 / progressBar.visualPosition更改为0,这可能会导致颜色渐变在进度条的顶部显示,而不是在底部。
  • Timer对象的interval属性在动画循环中没有改变,这可能导致动画速度不一致。
  • onTriggered槽函数中,moveTimer.interval = 2000的赋值应该在moveTimer.interval的当前值基础上进行更改,以避免在动画开始时立即设置为2000。
  • indeterminateMoveTimerinterval属性在动画循环中没有改变,这可能导致动画速度不一致。
  • onTriggered槽函数中,indeterminateMoveTimer.interval = 2000的赋值应该在indeterminateMoveTimer.interval的当前值基础上进行更改,以避免在动画开始时立即设置为2000。
  • count属性被添加到RectangleGradient对象中,但没有看到对count属性的使用或逻辑处理,这可能是不必要的代码。
  • lightPosition属性在RectangleGradient对象中被重复定义,这可能是一个重复的代码块。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants