Skip to content

chore: toolbutton hovered background tweak - #369

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:dev/animation
Aug 5, 2024
Merged

chore: toolbutton hovered background tweak#369
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:dev/animation

Conversation

@kegechen

@kegechen kegechen commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

hovered background sacled from 0.9 to 1.0

hovered background sacled from 0.9 to 1.0
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • PropertyChanges中新增的scale属性值与父组件的默认值相同,可能不需要添加
  • State块中的scale属性值在checked状态下的值被修改,但未提供上下文说明为什么需要修改
  • 新增的scale属性值0.9可能与现有样式或行为不协调,需要确认是否符合设计要求

是否建议立即修改:

  • 是,需要确认新增的PropertyChanges是否真的必要,并确保scale属性的修改不会影响组件的预期行为和样式。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#369
@deepin-bot

deepin-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
kegechen merged commit 8e37765 into linuxdeepin:dev/animation Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants