Skip to content

fix: icon too small when devicePixelRatio > 1.0 - #370

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:dev/animation
Aug 7, 2024
Merged

fix: icon too small when devicePixelRatio > 1.0#370
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
kegechen:dev/animation

Conversation

@kegechen

@kegechen kegechen commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

dciplayer has already set the devicePixelRatio, no need to divide by it here

dciplayer has already set the devicePixelRatio, no need to divide by it here
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 移除了对Qt版本检查的注释代码,需要确认这是否是有意为之。
  • 移除了devicePixelRatio的计算,如果这是为了修复某些问题,需要确保这一改动不会影响其他使用该代码的逻辑。

是否建议立即修改:

  • 是,需要确认移除代码的意图是否正确,并确保不会对现有功能产生负面影响。如果移除代码是为了修复已知的问题,建议在提交信息中说明原因。如果移除代码是无意的,应该立即恢复。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#370
@kegechen
kegechen requested a review from 18202781743 August 6, 2024 08:31
@deepin-bot

deepin-bot Bot commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
kegechen merged commit 63952bc into linuxdeepin:dev/animation Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants