Skip to content

fix: column layout fills the space available - #371

Merged
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:expanding
Aug 8, 2024
Merged

fix: column layout fills the space available#371
kegechen merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:expanding

Conversation

@FeiWang1119

Copy link
Copy Markdown

it's senseless that column layout fills the space available in ControlGroup,
so set Layout.fillHeight to false

Log:

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 7, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#371
it's senseless that column layout fills the space available in ControlGroup,
so set Layout.fillHeight to false

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 7, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#371
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ColumnLayoutitemLayout中添加了Layout.fillHeight: false属性,这可能会影响布局的预期行为。需要确认这是否是预期的更改。
  • 移除了clip属性,这可能会影响子控件的显示范围,需要确保这是否是预期的更改。

是否建议立即修改:

  • 是,需要确认这些更改是否符合设计要求,并确保它们不会引入新的问题。如果这些更改是错误的,应该立即恢复或进行必要的修正。

@deepin-bot

deepin-bot Bot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

@kegechen
kegechen merged commit 6e35d27 into linuxdeepin:dev/animation Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants