Skip to content

Listview hover - #373

Merged
kegechen merged 3 commits into
linuxdeepin:dev/animationfrom
kegechen:listview_hover
Aug 15, 2024
Merged

Listview hover#373
kegechen merged 3 commits into
linuxdeepin:dev/animationfrom
kegechen:listview_hover

Conversation

@kegechen

@kegechen kegechen commented Aug 9, 2024

Copy link
Copy Markdown
Contributor
  • hover background color tweak
  • avoid warnning
  • fix drag item image pixelated

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#373
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 9, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#373
@deepin-bot

deepin-bot Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

Comment thread qt6/src/qml/private/ButtonPanel.qml Outdated
Comment thread qt6/src/qml/ButtonBox.qml
NumberAnimation { target: backgroundPanel; property: "y"; to: btnGroup.checkedButton.y; duration: 200 }
NumberAnimation { target: backgroundPanel; property: "width"; to: btnGroup.checkedButton.width; duration: 200 }
NumberAnimation { target: backgroundPanel; property: "height"; to: btnGroup.checkedButton.height; duration: 200 }
NumberAnimation { target: backgroundPanel; property: "x"; to: btnGroup.checkedButton ? btnGroup.checkedButton.x : backgroundPanel.x; duration: 200 }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不会有循环绑定么?当btnGroup.checkedButton为null时, target: backgroundPanel的x 被赋值为 backgroundPanel.x,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不会

light: #000000 %10
dark:  #ffffff %10
read property from null
image size == item size
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 15, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#373
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • ButtonBox.qml中,NumberAnimationto属性现在根据btnGroup.checkedButton的存在性来决定是否使用btnGroup.checkedButton的属性值。这可能是一个逻辑错误,应该检查是否有更合适的条件来决定动画的目标值。
  • DragItemsImage.qml中,img.widthimg.height现在直接设置为itemwidthheight属性,这可能会导致图像尺寸与实际内容不匹配。应该检查item是否有相应的widthheight属性,并确保图像的尺寸是正确的。
  • ListView.qml中,enableAnimation属性被添加到ButtonPanel组件中,但未提供注释说明其用途。应该添加适当的注释来解释这个属性的作用。
  • ButtonPanel.qml中,enableAnimation属性的计算逻辑可能不正确。control.D.ColorSelector.controlState === D.DTK.HoveredStatecontrol.D.ColorSelector.family === D.Palette.CommonColor的条件应该检查control对象是否存在,并且D.DTK.HoveredStateD.Palette.CommonColor是有效的枚举值。

是否建议立即修改:

@kegechen
kegechen merged commit dc498fa into linuxdeepin:dev/animation Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants