fix: tooltip crashed while application exit - #381
Conversation
fix the clean job of blurnode Issue: linuxdeepin/dtk#193
deepin pr auto review关键摘要:
是否建议立即修改:
|
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#381
|
Doc Check bot |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: FeiWang1119, kegechen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| blurNode->setRenderCallback(onRender, this); | ||
| node->appendChildNode(blurNode); | ||
| node->setRenderCallback(updateBlurNodeTexture, blurNode); | ||
| connect(this, &QObject::destroyed, this, [node, blurNode](){ |
There was a problem hiding this comment.
正常情况下, quickitem销毁了, node应该也被销毁把, 不需要去重置这个callback,
There was a problem hiding this comment.
node可能会比item晚一点销毁，因为渲染可能是在一个新线程里，如果在渲染中销毁了item，它的node是不会立即销毁的。但是这里也不应该这样改，应该在 node 调用 callback之前检查 setRenderCallback中给出来的第二个参数。
| blurNode->setRenderCallback(onRender, this); | ||
| node->appendChildNode(blurNode); | ||
| node->setRenderCallback(updateBlurNodeTexture, blurNode); | ||
| connect(this, &QObject::destroyed, this, [node, blurNode](){ |
There was a problem hiding this comment.
node可能会比item晚一点销毁，因为渲染可能是在一个新线程里，如果在渲染中销毁了item，它的node是不会立即销毁的。但是这里也不应该这样改，应该在 node 调用 callback之前检查 setRenderCallback中给出来的第二个参数。
|
暂时close，不是这里的问题 @FeiWang1119 |
5 participants
fix the clean job of blurnode
Issue: linuxdeepin/dtk#193