Skip to content

chore: tweak the menu animation - #386

Merged
FeiWang1119 merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:menu
Aug 22, 2024
Merged

chore: tweak the menu animation#386
FeiWang1119 merged 1 commit into
linuxdeepin:dev/animationfrom
FeiWang1119:menu

Conversation

@FeiWang1119

Copy link
Copy Markdown

tweak the menu animation

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 21, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
@FeiWang1119
FeiWang1119 requested a review from kegechen August 21, 2024 08:30
@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 21, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
tweak the menu animation

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 22, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#386
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • FlowStyle.qml中,radius属性的默认值从18变更为12,需要确认这是否是预期的更改。
  • Menu.qml中,color属性从直接引用DS.Style.highlightPanel.background变更为一个动态计算的属性,这可能会影响样式的一致性和性能。
  • Menu.qml中,新增了BoxInsetShadow组件,需要验证其添加是否符合UI设计规范,并且是否与现有的组件和布局策略兼容。
  • Menu.qml中,BoxInsetShadow组件的属性visible被赋值为highlightRect.color === highlightRect.D.ColorSelector.backgroundColor,这可能是一个条件判断,但需要确保这种逻辑处理是正确的,并且不会影响用户界面的预期行为。

是否建议立即修改:

  • 是,特别是如果radius属性的默认值更改会影响到其他组件或样式,需要立即验证其正确性。
  • 是,如果color属性的更改影响了用户界面的视觉样式,或者如果动态计算导致了性能问题,需要立即评估其影响并可能需要修正。
  • 是,如果BoxInsetShadow组件的添加没有经过充分的设计和测试,或者其逻辑判断不正确,需要立即进行修正。

@FeiWang1119
FeiWang1119 merged commit d15afaa into linuxdeepin:dev/animation Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants