Skip to content

fix: StyledBehindWindowBlur crash in render thread #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Oct 31, 2024
Merged

fix: StyledBehindWindowBlur crash in render thread #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/private/dquickbehindwindowblur.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Q_DECL_HIDDEN DSGBlendNode : public QSGRenderNode
}

bool m_isRestore = false;
DQuickBehindWindowBlur *m_item = nullptr;
QPointer<DQuickBehindWindowBlur> m_item = nullptr;
QMatrix4x4 m_lastMatrix;
QRegion m_lastClip;
qreal m_lastRadius = -1;
Expand All @@ -47,7 +47,10 @@ DSGBlendNode::DSGBlendNode(bool restore)

void DSGBlendNode::render(const QSGRenderNode::RenderState *state)
{
Q_ASSERT(m_item);
// m_item may become invalid when the referred blur behind item get destroyed by a Loader.
// Give up rendering in this case.
if (!m_item)
return;

if (m_isRestore)
return;
Expand Down