Skip to content

chore: correct typos about Dtk::Gui::DDciIcon::IconAttribute - #202

Closed
felixonmars wants to merge 1 commit into
linuxdeepin:masterfrom
felixonmars:fix-typo
Closed

chore: correct typos about Dtk::Gui::DDciIcon::IconAttribute#202
felixonmars wants to merge 1 commit into
linuxdeepin:masterfrom
felixonmars:fix-typo

Conversation

@felixonmars

@felixonmars felixonmars commented Sep 30, 2023

Copy link
Copy Markdown
Member

Log:

@deepin-ci-robot

deepin-ci-robot commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/util/ddciicon.h 88 Dtk::Gui::DDciIcon::Q_FLAGS

kegechen
kegechen reviewed Oct 9, 2023
View reviewed changes

@kegechen kegechen left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

会引起接口变动，谨慎点
是否废弃旧的然后增加新的？
dtk6 统一删除typo接口

asterwyx
asterwyx requested changes Oct 13, 2023
View reviewed changes

@asterwyx asterwyx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

涉及到api变动需要以兼容的方式进行修改，建议在DTK5的环境下添加using IconAttibute=IconAttribute;

@deepin-bot

deepin-bot Bot commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #214

@deepin-bot

deepin-bot Bot commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #219

@deepin-bot

deepin-bot Bot commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #227

@deepin-bot

deepin-bot Bot commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #229

@deepin-bot

deepin-bot Bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #233

@deepin-bot

deepin-bot Bot commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #237

@deepin-bot

deepin-bot Bot commented May 16, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #239

@deepin-bot

deepin-bot Bot commented May 31, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #241

@deepin-bot

deepin-bot Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #243

@deepin-bot

deepin-bot Bot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #245

@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #251

@deepin-bot

deepin-bot Bot commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #256

@deepin-bot

deepin-bot Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #271

@deepin-bot

deepin-bot Bot commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #273

@deepin-bot

deepin-bot Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #287

@deepin-bot

deepin-bot Bot commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #289

@deepin-bot

deepin-bot Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #295

@18202781743

18202781743 commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

#297

@18202781743 18202781743 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asterwyx asterwyx asterwyx requested changes
+1 more reviewer
@kegechen kegechen kegechen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixonmars @deepin-ci-robot @18202781743 @kegechen @asterwyx