Skip to content

feat: Add notitlebar function on wayland platform - #210

Closed
FeiWang1119 wants to merge 1 commit into
linuxdeepin:masterfrom
FeiWang1119:wayland
Closed

feat: Add notitlebar function on wayland platform#210
FeiWang1119 wants to merge 1 commit into
linuxdeepin:masterfrom
FeiWang1119:wayland

Conversation

@FeiWang1119

Copy link
Copy Markdown
Contributor

add notitlebar function on wayland platform

Log: add notitlebar function on wayland platform

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 8, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#210
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 8, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#210
add notitlebar function on wayland platform

Log: add notitlebar function on wayland platform
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 8, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#210
Comment thread src/CMakeLists.txt
target_link_libraries(${LIB_NAME} PUBLIC
PUBLIC
Qt::Core
Qt::Widgets

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Widgets ?gui 里面怕是不应该加这个

@@ -0,0 +1,82 @@
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL ?license 检查一下

#include "dplatformhandle.h"
#include "dplatformtheme.h"
#include "dwindowmanagerhelper.h"
#include "wayland/dcontextshellwindow.h"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种应该要加上编译宏,不然非 wayland(treeland)的可能有编译问题

kegechen pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 20, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#210
return new DContextShellWindow(window);
}

DContextShellWindow *DContextShellWindow::qmlAttachedProperties(QObject *object)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数不需要,外部用不到,


class DContextShellWindowPrivate;

class DContextShellWindow : public QObject

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个类会导出去么,如果会的可以用d指针,不导出去的话,可以放到private里,
加上命名空间,

public:
~DContextShellWindow() override;

int noTitlebar();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对外的应该是bool类型的,跟协议可以不一样,

{
s_map.insert(window, this);
window->create();
auto waylandWindow = dynamic_cast<QtWaylandClient::QWaylandWindow *>(window->handle());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一部分可以放到 get函数里,这样的话可以返回nullptr作为无法创建的标志,外部可以fallback到其它方式去处理notitiebal这种,

@deepin-bot

deepin-bot Bot commented Jan 9, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #214

@deepin-bot

deepin-bot Bot commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #219

@kegechen
kegechen marked this pull request as draft February 29, 2024 02:16
@deepin-bot

deepin-bot Bot commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #227

@deepin-bot

deepin-bot Bot commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #229

@deepin-bot

deepin-bot Bot commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #233

@deepin-bot

deepin-bot Bot commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #237

@deepin-bot

deepin-bot Bot commented May 16, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #239

@deepin-bot

deepin-bot Bot commented May 31, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #241

@deepin-bot

deepin-bot Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #243

@deepin-bot

deepin-bot Bot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #245

@deepin-bot

deepin-bot Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants