Skip to content

chore: dplatformhandle tweak - #220

Closed
kegechen wants to merge 1 commit into
linuxdeepin:masterfrom
kegechen:5743
Closed

chore: dplatformhandle tweak#220
kegechen wants to merge 1 commit into
linuxdeepin:masterfrom
kegechen:5743

Conversation

@kegechen

Copy link
Copy Markdown
Contributor
  1. check systemtheme is valid
  2. typo fix. CreatorWindowEventFile==>WindowCreateEvenFilter

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 22, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#220
@deepin-bot

deepin-bot Bot commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

Comment thread src/kernel/dplatformhandle.cpp Outdated
Comment thread src/kernel/dplatformhandle.cpp
@kegechen
kegechen requested review from 18202781743 and zccrs January 22, 2024 05:30
@kegechen

Copy link
Copy Markdown
Contributor Author

Comment thread src/kernel/dplatformhandle.cpp Outdated
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 22, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#220
@kegechen
kegechen requested a review from zccrs January 22, 2024 07:28
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jan 23, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#220
1. check systemtheme is valid
2. typo fix. CreatorWindowEventFile==>WindowCreateEvenFilter
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Feb 29, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#220
setWindowProperty(window, _windowRadius, radius);
if (theme->isValid()) {
int radius = theme->windowRadius(18); //###(zccrs): 暂时在此处给窗口默认设置为18px的圆角
setWindowProperty(window, _windowRadius, radius);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme 无效时是不是应该直接设置为18?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那就没有必要检查valid了。

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #227

@kegechen

Copy link
Copy Markdown
Contributor Author

abandon

@kegechen kegechen closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants