fix: wrong availableSizes for DIconProxyEngine - #228
Merged
Conversation
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Mar 7, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#228
kegechen
approved these changes
Mar 7, 2024
Contributor
|
Doc Check bot
|
Contributor
|
TAG Bot New tag: 5.6.25 |
We should call proxy's `availableSizes` function. `availableSizes` always return empty list for icons, it causes `QPainter::begin: Paint device returned engine == 0` when painting to QImage.
18202781743
force-pushed
the
wrong-avaiablesize
branch
from
March 12, 2024 01:55
efaeb5d to
535f2dc
Compare
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Mar 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#228
BLumia
approved these changes
Mar 12, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, kegechen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Mar 12, 2024
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should call proxy's
availableSizesfunction.availableSizesalways return empty list for icons, it causesQPainter::begin: Paint device returned engine == 0when paintingto QImage.