chore: add some interfaces about personalization by FeiWang1119 · Pull Request #258 · linuxdeepin/dtkgui

FeiWang1119 · 2024-10-10T06:08:17Z

add some interfaces about personalization

Log:

deepin-ci-robot · 2024-10-10T06:08:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

deepin-ci-robot · 2024-10-15T11:43:08Z

deepin pr auto review

zccrs · 2024-10-15T12:10:20Z

先不要作为public接口，先作为private的，不对外可见

zccrs · 2024-10-15T12:14:30Z

+    virtual int windowRadius() const;
+    virtual void setWindowRadius(int windowRadius);
+    virtual QByteArray fontName() const;
+    virtual void setFontName(const QByteArray &fontName);


这种系统全局类的配置的修改不在 dtkgui 里提供，dtkgui里只读，不实现修改的功能。

就算要做修改的功能，也应该是在 dtksystemsettings 模块里做。

zccrs · 2024-10-15T12:15:57Z

+    virtual ~DPlatformInterface();
+
+    virtual int windowRadius() const;
+    virtual void setWindowRadius(int windowRadius);


如果是针对某个窗口的，那可以留着设置接口

zccrs · 2024-10-15T12:17:16Z

作为一个单独的cmake模块放到一个子目录里，目录以 plugins/platform 开头，比如是 plugins/platform/xcb

同样的也应该是 private 的，不对外

zccrs · 2024-10-15T12:20:53Z

-        if (contextWindow->noTitlebar() == enable)
-            return true;
-        contextWindow->setNoTitlebar(enable);
+#ifndef DTK_DISABLE_TREELAND


这部分为什么没有拆到 DPlatformHandle 里去？

zccrs · 2024-10-15T12:21:09Z

 void DPlatformHandle::setWindowRadius(int windowRadius)
 {
+#ifndef DTK_DISABLE_TREELAND
+    if (DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::IsTreelandPlatform)) {


zccrs · 2024-10-15T12:21:42Z

+{
+}
+
+int DPlatformInterface::windowRadius() const


可以直接是纯虚函数

zccrs · 2024-10-15T12:21:56Z

 DPlatformThemePrivate::DPlatformThemePrivate(Dtk::Gui::DPlatformTheme *qq)
    : DNativeSettingsPrivate(qq, QByteArrayLiteral("/deepin/palette"))
 {
-


为啥删了

zccrs · 2024-10-15T12:23:34Z

+    : QWaylandClientExtensionTemplate<PersonalizationManager>(1)
+{
+    if (QGuiApplication::platformName() == QLatin1String("wayland")) {
+        QtWaylandClient::QWaylandIntegration *waylandIntegration = static_cast<QtWaylandClient::QWaylandIntegration *>(QGuiApplicationPrivate::platformIntegration());


Qt6版本不是这样使用了吧，它不是有了 QNativeInterface 这种东西

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

deepin-bot · 2024-10-31T02:26:01Z

TAG Bot

New tag: 5.7.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #256

deepin-bot · 2024-11-15T05:48:14Z

TAG Bot

New tag: 5.7.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #271

deepin-bot · 2024-11-22T02:30:22Z

TAG Bot

New tag: 5.7.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #273

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

add window platform interface Log: as title.

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 10, 2024

sync: from linuxdeepin/dtkgui

72386fa

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

deepin-ci-robot mentioned this pull request Oct 10, 2024

sync: from linuxdeepin/dtkgui linuxdeepin/dtk6gui#64

Closed

FeiWang1119 force-pushed the master branch from 7e79d03 to a7d021d Compare October 10, 2024 13:38

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 10, 2024

sync: from linuxdeepin/dtkgui

aaa12ab

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from a7d021d to 2aa55f1 Compare October 11, 2024 09:18

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 11, 2024

sync: from linuxdeepin/dtkgui

2a438b7

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 2aa55f1 to 9186aaa Compare October 11, 2024 09:45

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 11, 2024

sync: from linuxdeepin/dtkgui

3ac720a

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 9186aaa to 14925b6 Compare October 12, 2024 02:56

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

8964f76

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 14925b6 to 0fcb72d Compare October 12, 2024 03:09

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

40ab9ac

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 0fcb72d to d0ebd9f Compare October 12, 2024 03:16

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

87d4dde

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from d0ebd9f to ca04058 Compare October 12, 2024 03:21

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

d877b4e

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from ca04058 to c0e82d0 Compare October 12, 2024 05:14

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

afe3335

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from c0e82d0 to 85a651a Compare October 12, 2024 05:17

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

786810a

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 85a651a to 472761c Compare October 12, 2024 05:51

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

5dab09c

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 472761c to 1e04332 Compare October 12, 2024 05:52

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

b51fe56

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

kegechen requested review from 18202781743 and justforlxz and removed request for justforlxz October 12, 2024 06:33

FeiWang1119 force-pushed the master branch from 1e04332 to c120e71 Compare October 12, 2024 06:36

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

b94b57a

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 12, 2024

sync: from linuxdeepin/dtkgui

3b2dbb6

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

18202781743 reviewed Oct 14, 2024

View reviewed changes

Comment thread src/CMakeLists.txt Outdated

Comment thread src/kernel/dplatformtheme.cpp Outdated

FeiWang1119 requested a review from zccrs October 14, 2024 12:51

zccrs requested changes Oct 14, 2024

View reviewed changes

FeiWang1119 force-pushed the master branch from f12a344 to fdcd14e Compare October 15, 2024 09:03

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 15, 2024

sync: from linuxdeepin/dtkgui

d89275b

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from fdcd14e to c61dbc6 Compare October 15, 2024 09:15

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 15, 2024

sync: from linuxdeepin/dtkgui

e39f499

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from c61dbc6 to e781599 Compare October 15, 2024 09:21

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 15, 2024

sync: from linuxdeepin/dtkgui

b18d51d

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from e781599 to 6ca3502 Compare October 15, 2024 11:41

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 15, 2024

sync: from linuxdeepin/dtkgui

a8d922e

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from 6ca3502 to 8b323ac Compare October 15, 2024 11:42

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 15, 2024

sync: from linuxdeepin/dtkgui

a536daa

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

zccrs requested changes Oct 15, 2024

View reviewed changes

FeiWang1119 force-pushed the master branch from 8b323ac to c961816 Compare October 17, 2024 07:34

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 17, 2024

sync: from linuxdeepin/dtkgui

2202279

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 force-pushed the master branch from c961816 to f828f0d Compare October 17, 2024 07:45

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Oct 17, 2024

sync: from linuxdeepin/dtkgui

76b94c7

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 marked this pull request as draft October 23, 2024 05:22

FeiWang1119 force-pushed the master branch from f828f0d to 687b2ff Compare November 28, 2024 06:50

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 28, 2024

sync: from linuxdeepin/dtkgui

4d6b80a

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

chore: add window platform interface

967a5a4

add window platform interface Log: as title.

FeiWang1119 force-pushed the master branch from 687b2ff to 967a5a4 Compare November 28, 2024 06:52

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 28, 2024

sync: from linuxdeepin/dtkgui

b22d4a4

Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#258

FeiWang1119 closed this Nov 28, 2024

Uh oh!

Conversation

FeiWang1119 commented Oct 10, 2024

Uh oh!

deepin-ci-robot commented Oct 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepin-ci-robot commented Oct 15, 2024

deepin pr auto review

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepin-bot Bot commented Oct 31, 2024

Uh oh!

deepin-bot Bot commented Nov 15, 2024

Uh oh!

deepin-bot Bot commented Nov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants