Skip to content

refactor: xcb platform theme interface - #274

Closed
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:featXcb
Closed

refactor: xcb platform theme interface#274
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:featXcb

Conversation

@mhduiy

@mhduiy mhduiy commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mhduiy
mhduiy marked this pull request as draft November 20, 2024 05:14
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 20, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 20, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 20, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
@mhduiy mhduiy changed the title xcb refactor: xcb platform theme interface Nov 20, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 21, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
@mhduiy
mhduiy requested a review from 18202781743 November 21, 2024 07:41
18202781743
18202781743 previously approved these changes Nov 21, 2024
@mhduiy
mhduiy marked this pull request as ready for review November 21, 2024 07:45
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 21, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
@mhduiy
mhduiy requested a review from kegechen November 21, 2024 08:03
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 21, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
FeiWang1119
FeiWang1119 previously approved these changes Nov 21, 2024
@mhduiy
mhduiy requested a review from zccrs November 21, 2024 09:23
Comment thread src/plugins/dplatforminterface.h Outdated
Comment thread src/plugins/dplatforminterface.h Outdated
Comment thread src/kernel/dplatformtheme.cpp Outdated
@deepin-bot

deepin-bot Bot commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.7.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #273

18202781743
18202781743 previously approved these changes Nov 22, 2024
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
mhduiy requested a review from zccrs November 22, 2024 10:11
Comment thread src/private/dplatforminterface_p.h Outdated
Comment thread src/private/dplatformtheme_p.h
Comment thread src/kernel/dplatformtheme.cpp
@zccrs

zccrs commented Nov 22, 2024

Copy link
Copy Markdown
Member

/+1

将DPlatformTheme中的接口抽象出来,不再写死dxcb,方便之后扩展其他平台的个性化接口

Log:
pms: Task-365811
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 22, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#274
@mhduiy mhduiy closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants