适配dconfig2cpp - #309
Conversation
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#309
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1468,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#309
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1468,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#309
|
@18202781743 这个提交的功能需要你验证下 |
deepin pr auto review代码审查意见：
|
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1468,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
|
TAG Bot New tag: 5.7.13 |
|
TAG Bot New tag: 5.7.14 |
Maybe start from 6.8.1
The org.deepin.dtk.preference.json file is not in this project, so we can't generated codes by cmake.
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#309
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1468,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
There was a problem hiding this comment.
Pull Request Overview
This PR adapts the configuration system to use asynchronous read/write via the new OrgDeepinDTKPreference API, replacing the old DConfig-based approach.
- Updated pixmap access in XdgIconProxyEngine using QT version conditionals
- Replaced DConfig usages with OrgDeepinDTKPreference in theme-related files
- Updated signal connections in the application helper to use the new API
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util/private/xdgiconproxyengine.cpp | Introduces conditional compilation to use an updated pixmap API |
| src/private/dplatformtheme_p.h | Replaces DConfig with a forward-declared OrgDeepinDTKPreference pointer |
| src/kernel/dplatformtheme.cpp | Updates theme configuration to rely on new OrgDeepinDTKPreference APIs |
| src/kernel/dguiapplicationhelper.cpp | Uses new global static OrgDeepinDTKPreference and signal changes |
Files not reviewed (2)
- .reuse/dep5: Language not supported
- src/kernel/kernel.cmake: Language not supported
Comments suppressed due to low confidence (3)
src/util/private/xdgiconproxyengine.cpp:193
- [nitpick] The hardcoded scaling factor (1.0) could be defined as a named constant to improve clarity and facilitate future adjustments.
return entry->pixmap(size, mode, state, 1.0);
src/kernel/dguiapplicationhelper.cpp:459
- [nitpick] Consider using _d_dconfig() instead of _d_dconfig.operator ()() for clarity when accessing the global static instance.
QObject::connect(_d_dconfig.operator ()(), &OrgDeepinDTKPreference::themeTypeChanged, _d_dconfig, [applyThemeType] {
src/kernel/dplatformtheme.cpp:114
- Verify that the return value from dtkPreferenceConfig->sizeMode() is guaranteed to be within the valid range for DGuiApplicationHelper::SizeMode to avoid potential mismatches.
d->sizeMode = static_cast<DGuiApplicationHelper::SizeMode>(d->dtkPreferenceConfig->sizeMode());
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
测试过调色板，滚动条，紧凑模式，没问题， |
OK，那就合入了 |
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#309
使用异步方式读写DConfig配置