Skip to content

Revert "fix: 自定义页码切换问题" - #566

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
ArchieMeng:master
May 11, 2024
Merged

Revert "fix: 自定义页码切换问题"#566
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
ArchieMeng:master

Conversation

@ArchieMeng

Copy link
Copy Markdown
Contributor

Do not reset custom page ranges when changing printers/page size/Anything like this.

Issue: linuxdeepin/developer-center#7983
Log: revert f53dfff

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 26, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
@deepin-bot

deepin-bot Bot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 28, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 28, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566

@kegechen kegechen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit msg 改一下。。。

@ArchieMeng ArchieMeng changed the title revert: Revert f53dfffb63cfcd3f005019fcc2057c652c20822b revert: Revert "fix: 自定义页码切换问题" Apr 29, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 29, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 29, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
@deepin-bot

deepin-bot Bot commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

TAG Bot

New tag: 5.6.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #568

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 30, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, kegechen

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen changed the title revert: Revert "fix: 自定义页码切换问题" Revert "fix: 自定义页码切换问题" May 8, 2024
@kegechen

kegechen commented May 8, 2024

Copy link
Copy Markdown
Contributor

/retest

Do not reset custom page ranges when changing printers, page
size or anything else like this.

Issue: linuxdeepin/developer-center#7983
Log: revert f53dfff
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • DPrintPreviewDialogPrivate::initconnections函数中,_q_customPagesFinished函数的调用似乎不正确ly season3 是什么

@kegechen

Copy link
Copy Markdown
Contributor

/help

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request May 11, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

@kegechen:

deepin pr commands help details.

常用命令:

  • /integrate 集成单个包
  • /topic $name 添加pr到topic
  • /integr-topic $name 集成topic,只需要在任意一个pr中输入一次即可,topic有更新在重新刷一次
  • /merge 没有开机器人自动合并的用这个合并代码
  • /retest 重试出错的ci任务,/test all 执行所有ci任务,/test $name执行指定的ci任务
  • /check obs linuxdeepin组织下专属命令,应对该组织下obs ci任务未成功执行的情况,执行后仍然有问题可以有节奏的关闭-->打开pr一下,还是有问题可以急call管理员
Details

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kegechen

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented May 11, 2024

Copy link
Copy Markdown
Contributor

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 44bf163 into linuxdeepin:master May 11, 2024
kegechen pushed a commit to linuxdeepin/dtk6widget that referenced this pull request May 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants